New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658954 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
dbeam@chromium.org
█ tsergeant@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

CrSearchFieldBehavior can result in infinite 'search-changed' events fired.

Project Member Reported by dpa...@chromium.org, Oct 25 2016 
Calling setValue() from within a 'search-changed' event handler results in an infinite loop, because the event is fired before this.lastValue_ is updated.

Better explained by the fix and corresponding test, see https://codereview.chromium.org/2447973002.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b9eb5729e14ff59468a19095cd35a46dc8eb7cd

commit 1b9eb5729e14ff59468a19095cd35a46dc8eb7cd
Author: dpapad <dpapad@chromium.org>
Date: Tue Oct 25 19:03:48 2016

CrSearchFieldBehavior: Fix case where infinite 'search-changed' events are fired.

BUG= 658954 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2447973002
Cr-Commit-Position: refs/heads/master@{#427431}

[modify] https://crrev.com/1b9eb5729e14ff59468a19095cd35a46dc8eb7cd/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/1b9eb5729e14ff59468a19095cd35a46dc8eb7cd/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js

Comment 2 by dpa...@chromium.org, Oct 25 2016

Status: Fixed (was: Started)
►

Sign in to add a comment