Issue metadata
Sign in to add a comment
|
Chromevox: Cvox orange highlight is broken in user sign in screen |
||||||||||||||||||||||||
Issue descriptionVersion: 55.0.2883.25 What steps will reproduce the problem? (1)Enable Cvox next and tab around in the user sign in screen What is the expected output? The orange highlight should should follow the spoken feedback What do you see instead? The orange highlight doses not follow the spoken feedback when Cvox reads the contents on the 'Sign into your Chromebook' box. ( EMail, Next , More options buttons )
,
Nov 15 2016
It is also broken on the new OOBE as well in M56. Let me know if you want me to file a separate issue for that
,
Mar 6 2017
,
Mar 21 2017
,
Mar 24 2017
Issue still seen on 58.0.3029.31
,
Mar 27 2017
,
Mar 27 2017
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7c9e55f9f13ae947e938b8a4c929fefdeffe397 commit c7c9e55f9f13ae947e938b8a4c929fefdeffe397 Author: dmazzoni <dmazzoni@chromium.org> Date: Wed Mar 29 16:21:49 2017 Fix computation of Automation API location offsets in WebViews. The user-visible error here was that when ChromeVox was enabled, the orange highlight around an object was sometimes wrong when inside a <webview>, like in the new OOBE. Previously, to get the global bounds of an object, we'd figure out the global bounds relative to the top frame, then use a location offset to convert from frame-relative coordinates to global screen coordinates. This wasn't correct for WebViews, because a WebView has its own frame tree and its own location offset, so the location offset was essentially being counted twice. It turns out that now that http://crbug.com/618120 is fixed, we don't need the location offset. Instead we should just walk up from any node all the way to the desktop root node, applying offsets and transforms as we go. That way there's a single consistent way to compute global bounding boxes that's the same everywhere, with no special cases for webview. This required a small fix to GetParent() to search the desktop tree if an explicit parent tree ID wasn't found. Includes a new location test with a WebView. BUG= 658947 , 618120 Review-Url: https://codereview.chromium.org/2762373002 Cr-Commit-Position: refs/heads/master@{#460412} [modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc [modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/common/extensions/chrome_extension_messages.h [modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/renderer/extensions/automation_internal_custom_bindings.h [add] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/test/data/extensions/api_test/automation/tests/webview/location_in_webview.js [add] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/test/data/extensions/api_test/automation/tests/webview/manifest.json [add] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html
,
Apr 21 2017
,
Apr 21 2017
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9713fc0690986ce27fb417f01fd715016fbaa46 commit e9713fc0690986ce27fb417f01fd715016fbaa46 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Mon May 08 21:03:02 2017 Merge to M59: Revert "Fix computation of Automation API location offsets in WebViews." This reverts commit c7c9e55f9f13ae947e938b8a4c929fefdeffe397. Originally landed: r460412: https://codereview.chromium.org/2762373002 BUG= 717684 , 658947 Review-Url: https://codereview.chromium.org/2867103005 . Cr-Commit-Position: refs/branch-heads/3071@{#462} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/browser/extensions/api/automation/automation_apitest.cc [modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc [modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/common/extensions/chrome_extension_messages.h [modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/renderer/extensions/automation_internal_custom_bindings.h [delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/location_in_webview.js [delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/manifest.json [delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html
,
Jun 12 2017
Issue 722888 has been merged into this issue.
,
Jun 28 2017
,
Jul 10 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Oct 26 2016