New issue
Advanced search Search tips

Issue 658947 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 692741



Sign in to add a comment

Chromevox: Cvox orange highlight is broken in user sign in screen

Project Member Reported by pbath...@chromium.org, Oct 25 2016

Issue description

Version: 55.0.2883.25

What steps will reproduce the problem?

(1)Enable Cvox next and tab around in the user sign in screen 

What is the expected output?

The orange highlight should should follow the spoken feedback

What do you see instead?

The orange highlight doses not follow the spoken feedback when Cvox reads the contents on the 'Sign into your Chromebook' box. ( EMail, Next , More options buttons ) 

 
IMG_2154.JPG
1.6 MB View Download
Status: Assigned (was: Untriaged)
It is also broken on the new OOBE as well in M56. Let me know if you want me to file a separate issue for that
Labels: NewComponent-Accessibility-ChromeVox
Blocking: 692741
Issue still seen on 58.0.3029.31
Labels: NewComponent-Accessibility
Cc: lfg@chromium.org dmazz...@chromium.org
 Issue 692741  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7c9e55f9f13ae947e938b8a4c929fefdeffe397

commit c7c9e55f9f13ae947e938b8a4c929fefdeffe397
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Mar 29 16:21:49 2017

Fix computation of Automation API location offsets in WebViews.

The user-visible error here was that when ChromeVox was enabled,
the orange highlight around an object was sometimes wrong when inside
a <webview>, like in the new OOBE.

Previously, to get the global bounds of an object, we'd figure out the
global bounds relative to the top frame, then use a location offset to
convert from frame-relative coordinates to global screen coordinates.

This wasn't correct for WebViews, because a WebView has its own frame tree
and its own location offset, so the location offset was essentially being
counted twice.

It turns out that now that  http://crbug.com/618120  is fixed, we don't need
the location offset. Instead we should just walk up from any node all the
way to the desktop root node, applying offsets and transforms as we go.
That way there's a single consistent way to compute global bounding boxes
that's the same everywhere, with no special cases for webview. This required
a small fix to GetParent() to search the desktop tree if an explicit parent
tree ID wasn't found.

Includes a new location test with a WebView.

BUG= 658947 , 618120 

Review-Url: https://codereview.chromium.org/2762373002
Cr-Commit-Position: refs/heads/master@{#460412}

[modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/common/extensions/chrome_extension_messages.h
[modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/renderer/extensions/automation_internal_custom_bindings.h
[add] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/test/data/extensions/api_test/automation/tests/webview/location_in_webview.js
[add] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/test/data/extensions/api_test/automation/tests/webview/manifest.json
[add] https://crrev.com/c7c9e55f9f13ae947e938b8a4c929fefdeffe397/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html

Components: UI>Accessibility>ChromeVox
Labels: -newcomponent-accessibility -newcomponent-accessibility-chromevox
Components: -UI>Accessibility
Project Member

Comment 11 by bugdroid1@chromium.org, May 8 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9713fc0690986ce27fb417f01fd715016fbaa46

commit e9713fc0690986ce27fb417f01fd715016fbaa46
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon May 08 21:03:02 2017

Merge to M59: Revert "Fix computation of Automation API location offsets in WebViews."

This reverts commit c7c9e55f9f13ae947e938b8a4c929fefdeffe397.

Originally landed: r460412: https://codereview.chromium.org/2762373002

BUG= 717684 , 658947 

Review-Url: https://codereview.chromium.org/2867103005 .
Cr-Commit-Position: refs/branch-heads/3071@{#462}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/common/extensions/chrome_extension_messages.h
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/e9713fc0690986ce27fb417f01fd715016fbaa46/chrome/renderer/extensions/automation_internal_custom_bindings.h
[delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/location_in_webview.js
[delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/manifest.json
[delete] https://crrev.com/8a4fb425dc1e081b5942975f0d1c852aae2819e6/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html

 Issue 722888  has been merged into this issue.
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment