Don't expose ES3 compressed formats if they are not supported natively |
||||||
Issue descriptionWebGL2 spec changed and it's been moved to an extension. 1) Remove the emulation for Mac Core profile 2) Don't expose them if underlying driver is Desktop (On Linux with ES3_Compatibility extension, these formats are emulated) or ANGLE (ANGLE ES3 has to emulate it, but WebGL2 (and command buffer) shouldn't expose it)
,
Oct 24 2016
,
Oct 24 2016
My bug is now specifically for making the query to the ANGLE. It is not a WebGL 2 blocker.
,
Oct 25 2016
Mo, should we remove the functionality or just update the validation at the WebGL level?
,
Oct 25 2016
Yeah, just updating whether or not exposing the extension sounds fine to me.
,
Nov 5 2016
Kai, can you also take this one? Making sure we only expose the ES3 compressed formats on ES3 for now (minus ANGLE).
,
Nov 7 2016
,
Nov 8 2016
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8477f6effb5584425e0f675e3326c334fccc19e7 commit 8477f6effb5584425e0f675e3326c334fccc19e7 Author: kainino <kainino@chromium.org> Date: Tue Nov 08 02:38:03 2016 disable ETC textures on ANGLE for now BUG= 658929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2481403002 Cr-Commit-Position: refs/heads/master@{#430487} [modify] https://crrev.com/8477f6effb5584425e0f675e3326c334fccc19e7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/8477f6effb5584425e0f675e3326c334fccc19e7/gpu/command_buffer/service/feature_info.cc
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4306f9b2ca2daba39c463f5aa54a7a931593a50 commit e4306f9b2ca2daba39c463f5aa54a7a931593a50 Author: kainino <kainino@chromium.org> Date: Wed Nov 16 22:50:21 2016 disable ETC1 on ANGLE's ES3 BUG= 658929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2499413003 Cr-Commit-Position: refs/heads/master@{#432655} [modify] https://crrev.com/e4306f9b2ca2daba39c463f5aa54a7a931593a50/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/e4306f9b2ca2daba39c463f5aa54a7a931593a50/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC1.cpp
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4c260ba044f3820a082c5bdb2336f837a4a841 commit 3e4c260ba044f3820a082c5bdb2336f837a4a841 Author: kainino <kainino@chromium.org> Date: Wed Dec 14 21:50:04 2016 Disable ETC1 textures on WebGL 1 on ANGLE BUG= 658929 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2576813002 Cr-Commit-Position: refs/heads/master@{#438638} [modify] https://crrev.com/3e4c260ba044f3820a082c5bdb2336f837a4a841/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/3e4c260ba044f3820a082c5bdb2336f837a4a841/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/3e4c260ba044f3820a082c5bdb2336f837a4a841/third_party/WebKit/Source/modules/webgl/WebGLCompressedTextureETC1.cpp
,
Jun 20 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zmo@chromium.org
, Oct 24 2016