MD Settings: Don't search for whitespace-only strings |
||||
Issue descriptionSettings should not execute a search when only whitespace is typed into the search box. (The spacebar is a common way of paging down.) 1. Open chrome://md-settings 2. Press <Spacebar> to page down Expected: A space is typed into the search box, because it's focused Actual: A space is typed into the search box, "No search results found" is shown, and the rest of the page follows below.
,
Oct 25 2016
,
Oct 25 2016
there's logic in downloads you should be able to borrow for this, I think
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8fb849e33552296a15f3dc131c7580b8d94b9fc commit d8fb849e33552296a15f3dc131c7580b8d94b9fc Author: dpapad <dpapad@chromium.org> Date: Fri Nov 04 17:55:36 2016 MD Settings: Ignore whitespace only search queries. BUG= 658922 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2446413002 Cr-Commit-Position: refs/heads/master@{#429949} [modify] https://crrev.com/d8fb849e33552296a15f3dc131c7580b8d94b9fc/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/d8fb849e33552296a15f3dc131c7580b8d94b9fc/chrome/test/data/webui/settings/settings_ui_browsertest.js
,
Nov 5 2016
,
Nov 22 2016
Verified on ChromeOS 9000.0.0, 56.0.2923.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Oct 24 2016