New issue
Advanced search Search tips

Issue 658918 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Settle down on the best Win10 Welcome Page variant

Project Member Reported by pmonette@chromium.org, Oct 24 2016

Issue description

There is currently 2 versions for the Win10 Welcome Page that
are styled differently. This is a tracking bug to get rid of
one of them when the A/B testing is done.
 
Curious - where can I view the Win10 Welcome Page variant?
P.S. I'm new so I'm not sure where to view the versions.
Thanks.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6501f0e4baf88ae9f950009a683a6c43b5624777

commit 6501f0e4baf88ae9f950009a683a6c43b5624777
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Nov 09 22:23:54 2017

Remove an unused layout for the Win10 welcome page

It turns out that it was never used so it can be safely deleted and the
code simplified.

Bug:  658918 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8026f1ae05ca614e3ad0a70b210539ebbf6891ef
Reviewed-on: https://chromium-review.googlesource.com/740781
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515320}
[modify] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/browser_resources.grd
[rename] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/resources/welcome/default.webp
[rename] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/resources/welcome/pin.webp
[rename] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/resources/welcome/welcome_win10.css
[rename] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/resources/welcome/welcome_win10.html
[rename] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/resources/welcome/welcome_win10.js
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/resources/welcome/win10/README.md
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/resources/welcome/win10/default-large.webp
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/resources/welcome/win10/pin-large.webp
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/resources/welcome/win10/sectioned.css
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/resources/welcome/win10/sectioned.html
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/resources/welcome/win10/sectioned.js
[modify] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/ui/startup/startup_features.cc
[delete] https://crrev.com/16294fbeb9719aff57089103f282453487e348a0/chrome/browser/ui/startup/startup_features.h
[modify] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/ui/webui/welcome_win10_handler.cc
[modify] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/ui/webui/welcome_win10_handler.h
[modify] https://crrev.com/6501f0e4baf88ae9f950009a683a6c43b5624777/chrome/browser/ui/webui/welcome_win10_ui.cc

Status: Fixed (was: Assigned)

Sign in to add a comment