zqzhang, mlamouri: You guys have been working around this code recently (MediaWebContentsObserver). Any relationship to your changes?

Do we use MediaWebContentsObserver for Flash?

No, we are using PepperPlaybackObserver, it's pretty much like how MediaWebContentsObserver works.

The Flash code we touched recently is not enabled in production. Also I wonder how it could affect screen wake lock.

Can confirm this is also present in the current dev build on windows (56.0.2896.3).

As well as the screen sleeping, I also have some jobs in task scheduler that are meant to be delayed if the system is busy. Usually these would execute after video playback, but now they just run while playback is occurring.

Tested the issue on Mac 10.11.6 and 10.12 using chrome version 56.0.2899.0  and 55.0.2883.22 with the below steps

1. Setup: in System Preferences > Energy Saver > Power Adapter, set "Turn off display after 1 minute".
2.go to URL https://www.youtube.com/watch?v=g_m017ebtD8
3.Play Video for 2 mins
4.Not observed any dimness of screen
5.Entered the command ~$ time cat in command prompt
4.Observed the error as " -bash: ~$: command not found"

Could you please confirm anything missed here.Not observed any difference in both versions tested 55.0.2883.22 and 56.0.2899.0 .

Thanks,

You used a YouTube link. Worth checking that you didn't use the HTML5 player? Issue only seems to occur when using flash for playback as per op.

I was watching iPlayer when getting the issue which uses flash.

I have the same problem (screensaver kicking on while watching video) on Windows with 56.0.2900.0.  Any stream from twitch.tv should work to reproduce it.

-Internals>Media. Marking as RBS.

Unable to reproduce the issue on Mac 10.11.6 and 10.12 using chrome version 56.0.2900.0 with the below URLS.
twitch.tv
https://www.youtube.com/watch?v=g_m017ebtD8

The below URLs provided are not accessible from here.Hence adding respective team to check.
http://www.cbs.com/shows/big_bang_theory/video/54A6A4EF-B32F-D95A-DCF6-BF8BA60868B5/the-big-bang-theory-the-hot-tub-contamination/
http://www.cwtv.com/shows/supernatural/keep-calm-and-carry-on/?play=6e4be1ba-de0e-4d4c-8c7c-290709664892
http://www.bbc.co.uk/iplayer/episode/b0813q5n/the-missing-series-2-3-a-prison-without-walls

@MTV team, Please check the issue with the URLS if accessible from your end.

Thanks,

Deleted: 658910.mp4 1.2 MB

	658910.mp4 1.2 MB View Download

Are you, perchance, leaving the mouse and keyboard alone while the video plays?  The problem isn't that chromium is forcing the screensaver/powersave mode on.  It should be preventing the screensaver/powersave mode from coming on while a video plays, but it isn't.  If you move the mouse or type on the keyboard, that would obviously prevent the screensaver/powersave mode from triggering and, therefore, hide the problem.

Able to reproduce this issue on reported version of Chrome#56.0.2899.0 for Os X 10.12 and working on a narrow bisect.

Here is the Change Log:
========================
https://chromium.googlesource.com/chromium/src/+log/56.0.2894.0..56.0.2895.0?pretty=fuller&n=10000

ccameron@, could you please look into this change (https://chromium.googlesource.com/chromium/src/+/04c2bac53d96749f85f9046d9923810df58d41c1) ?

Thank you!

Taking a look at this.

Ugh, this is getting harder and harder to debug.

It used to be that we could use the flag --ppapi-flash-path to allow Chromium to use flash. But now, all of those test pages don't see that we have the flash plugin. Do we have a way to report that we actually have the flash plugin?

That's worked for me as recently as last week. Are you using --ppapi-flash-version to specify the version?

Something like:
"""
out/gn/Chromium.app/Contents/MacOS/Chromium --ppapi-flash-path=/Applications/Google\ Chrome\ Canary.app/Contents/Versions/54.0.2808.0/Google\ Chrome\ Framework.framework/Internet\ Plug-Ins/PepperFlash/PepperFlashPlayer.plugin --ppapi-flash-version=22.0.0.209
"""

Yeah, that was what I was doing:

  --ppapi-flash-path=/Applications/Google\ Chrome.app/Contents/Versions/53.0.2785.143/Google\ Chrome\ Framework.framework/Internet\ Plug-Ins/PepperFlash/PepperFlashPlayer.plugin \

I used to be able to finagle twitch.tv into doing Flash instead of html5, but that has been failing lately.

I'll keep poking at this.

Okay, if you click the "you do not have flash installed" box on cwtv or cbs, it will pop up a "do you want to run flash" dialog, which gets it running.

Can't get youtube to do it, but that's fine -- I just need one working repro

So ... I had tested that the power blocker's lifetime was correct, but not that the blocker actually prevented sleep.

I used kPowerSaveBlockPreventAppSuspension, not kPowerSaveBlockPreventDisplaySleep ... the second one is the one I wanted.

Tested that this actually works now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ef11abdb743e2af6aaba409e9d123cfeb73b921

commit 0ef11abdb743e2af6aaba409e9d123cfeb73b921
Author: ccameron <ccameron@chromium.org>
Date: Wed Nov 02 19:45:42 2016

Flash: On activity, prevent display sleep, not just system sleep

BUG= 658910 

Review-Url: https://codereview.chromium.org/2462243004
Cr-Commit-Position: refs/heads/master@{#429370}

[modify] https://crrev.com/0ef11abdb743e2af6aaba409e9d123cfeb73b921/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

ccameron@, Thank you for the fix and it is working as intended on Mac OS X 10.12.1 for chrome#56.0.2920.0.