New issue
Advanced search Search tips

Issue 658906 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

The Android ViewStructure font size should be in Android pixels

Project Member Reported by dmazz...@chromium.org, Oct 24 2016

Issue description

The font size is currently in non-transformed CSS pixels, it should be first transformed to global coordinates, then converted from CSS pixels to Android pixels.

See b/29892155

 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0148879eff4f35f89c2882dae706a3b097c2c4a

commit c0148879eff4f35f89c2882dae706a3b097c2c4a
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Oct 25 19:13:20 2016

The Android ViewStructure font size should be in physical pixels

The font size in AccessibilityNodeInfo is the computed style for that
element. We need to convert it twice:

1. Convert that to global CSS coordinates, applying any transformations that
might affect the font size, such as CSS scale transformations. Covered by a
test.

2. Convert from CSS pixels to physical pixels. Not currently covered by a
test but seems straightforward if that's the correct way to interpret this
value.

BUG= 658906 

Review-Url: https://codereview.chromium.org/2443353003
Cr-Commit-Position: refs/heads/master@{#427436}

[modify] https://crrev.com/c0148879eff4f35f89c2882dae706a3b097c2c4a/content/browser/accessibility/browser_accessibility.h
[modify] https://crrev.com/c0148879eff4f35f89c2882dae706a3b097c2c4a/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/c0148879eff4f35f89c2882dae706a3b097c2c4a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/c0148879eff4f35f89c2882dae706a3b097c2c4a/content/public/android/javatests/src/org/chromium/content/browser/webcontents/AccessibilitySnapshotTest.java

Sign in to add a comment