base/test/launcher: Make --gtest_filter=A.B + --gtest_also_run_disabled_tests also run A.DISABLED_B or DISABLED_A.B or DISABLED_A.DISABLED_B |
|||
Issue description
Use case: rerun a gtest against pre-built artifacts at an arbitrary revision with the same gtest switches no matter whether the test is disabled or not. (We are using historical post-commit build artifacts on Swarming/Isolate to rerun flaky tests and try to figure out when the flake started.)
--gtest_filter=A.B --gtest_also_run_disabled_tests
Assumed A.B is already disabled by renaming to A.DISABLED_B (similar for DISABLED_A.B or DISABLED_A.DISABLED_B).
Currently without this change, the test is disabled, and won't be run by default unless you add to command line:
* -- gtest_also_run_disabled_tests
or
* --gtest_filter=A.DISABLED_B --gtest_also_run_disabled_tests
In the json test result produced by base/test/launcher, the test is referred to as A.DISABLED_B in the "per_iteration_data".
(But it is referred to as A.B in "all_tests" and "disabled_tests", which is inconsistent.)
After this change, the test is still disabled, and won't be run by default unless you add to command line:
* -- gtest_also_run_disabled_tests
or
* --gtest_filter=A.B --gtest_also_run_disabled_tests
In the json test result produced by base/test/launcher, the test is also referred to as A.B in the "per_iteration_data".
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9537aa9f56cc489b48b43bf638dda3968c28993d commit 9537aa9f56cc489b48b43bf638dda3968c28993d Author: stgao <stgao@chromium.org> Date: Mon Oct 31 21:38:44 2016 test launcher: make --gtest_filter=A.B + --gtest_also_run_disabled_tests also run A.DISABLED_B or DISABLED_A.B or DISABLED_A.DISABLED_B BUG= 658892 Review-Url: https://codereview.chromium.org/2439423003 Cr-Commit-Position: refs/heads/master@{#428827} [modify] https://crrev.com/9537aa9f56cc489b48b43bf638dda3968c28993d/base/test/gtest_util.cc [modify] https://crrev.com/9537aa9f56cc489b48b43bf638dda3968c28993d/base/test/gtest_util.h [modify] https://crrev.com/9537aa9f56cc489b48b43bf638dda3968c28993d/base/test/launcher/test_launcher.cc [modify] https://crrev.com/9537aa9f56cc489b48b43bf638dda3968c28993d/base/test/launcher/test_results_tracker.cc
,
Nov 2 2016
,
Nov 4 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by st...@chromium.org
, Oct 31 2016