New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 648728



Sign in to add a comment

base/test/launcher: Make --gtest_filter=A.B + --gtest_also_run_disabled_tests also run A.DISABLED_B or DISABLED_A.B or DISABLED_A.DISABLED_B

Project Member Reported by st...@chromium.org, Oct 24 2016

Issue description

Use case: rerun a gtest against pre-built artifacts at an arbitrary revision with the same gtest switches no matter whether the test is disabled or not. (We are using historical post-commit build artifacts on Swarming/Isolate to rerun flaky tests and try to figure out when the flake started.)
  --gtest_filter=A.B --gtest_also_run_disabled_tests

Assumed A.B is already disabled by renaming to A.DISABLED_B (similar for DISABLED_A.B or DISABLED_A.DISABLED_B).

Currently without this change, the test is disabled, and won't be run by default unless you add to command line:
     * -- gtest_also_run_disabled_tests
     or
     * --gtest_filter=A.DISABLED_B --gtest_also_run_disabled_tests
In the json test result produced by base/test/launcher, the test is referred to as A.DISABLED_B in the "per_iteration_data".
(But it is referred to as A.B in "all_tests" and "disabled_tests", which is inconsistent.)

After this change, the test is still disabled, and won't be run by default unless you add to command line:
     * -- gtest_also_run_disabled_tests
     or
     * --gtest_filter=A.B --gtest_also_run_disabled_tests
In the json test result produced by base/test/launcher, the test is also referred to as A.B in the "per_iteration_data".
 

Comment 1 by st...@chromium.org, Oct 31 2016

Blocking: 648728
Cc: -serg...@chromium.org

Comment 4 by st...@chromium.org, Nov 4 2016

Status: Fixed (was: Started)

Sign in to add a comment