New issue
Advanced search Search tips

Issue 658891 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Assert when rotating from landscape to portrait on specific site

Project Member Reported by amp@chromium.org, Oct 24 2016

Issue description

Version: 56.0.2900.0 (Developer Build)
$ git lg -1
* cf7070d - (HEAD, wip/master, origin/master, origin/HEAD) Removed uses of IsRunningOnIOS9OrLater in crw_web_ or wk_web_view_ (2 hours ago) <pkl>

$ gn args out/Default
enable_vr_shell = true
enable_webvr = true
target_os = "android"
is_component_build = true
disable_incremental_isolated_processes = true
is_clang = true
proprietary_codecs=true
ffmpeg_branding="Chrome"
use_goma = true

OS: Android 7.1.1 (Pixel Build/NMF20C)

Repro'ed on earlier builds and OS version as well, but I didn't note them at the time.

Current command line:
 chrome --use-mobile-user-agent --top-controls-show-threshold=0.5 --top-controls-hide-threshold=0.5 --use-mobile-user-agent --enable-pinch --enable-viewport --enable-overlay-scrollbar --validate-input-event-stream --enable-longpress-drag-selection --touch-selection-strategy=direction --disable-gpu-process-crash-limit --main-frame-resizes-are-orientation-changes --disable-composited-antialiasing --ui-prioritize-in-gpu-process --profiler-timing=0 --prerender-from-omnibox=enabled --enable-dom-distiller --flag-switches-begin --flag-switches-end --enable-instant-extended-api

What steps will reproduce the problem?
(1) Go to http://camendesign.com/code/video_for_everybody/test.html (I wasn't able to repro on any other site).
(2) Rotate the view to landscape
(3) Rotate the view to portrait

What is the expected output?
View should switch between landscape and portrait re-orientating text etc.

What do you see instead?
Aw, Snap!
Crash (see attached logs).

Please use labels and text to provide additional information.

Tagging to layout as that is where the assertion happens:
chromium/src/third_party/WebKit/Source/core/layout/LayoutText.h:324
  00a0fcc4  blink::LayoutText::computePreferredLogicalWidths(float, WTF::HashSet<blink::SimpleFontData const*, WTF::PtrHash<blink::SimpleFontData const>, WTF::HashTraits<blink::SimpleFontData const*>, WTF::PartitionAllocator>&, blink::FloatRect&)         

The assertion is actually ASSERT_WITH_SECURITY_IMPLICATION, but as this is a dev build I'm not filing it as a security bug (please correct me if I'm wrong on that).

Happens 100%, but only on one site.  It could be due to vr flags, still attempting to verify that.
 
rotation_crash.log
67.4 KB View Download

Comment 1 by e...@chromium.org, Oct 24 2016

Cc: drott@chromium.org kojii@chromium.org e...@chromium.org
Status: Available (was: Untriaged)
Summary: Assert when rotating from landscape to portrait on specific site (was: Crash when rotating from landscape to portrait)

Comment 2 by amp@chromium.org, Oct 25 2016

I verified that removing the vr build flags from my gn args does not fix the problem.

Comment 3 by kojii@chromium.org, Oct 26 2016

I tried the URL in #0 using Beta, Dev, and Canary (56.0.2900.3) with the default config but none of them reproduced for me. I used Android 7.0, Nexus 6P, NBD90X.

Haven't tried all the flags yet, but could you mind to confirm that if this is reproducible using one of official builds on your device?

Thought this maybe layout-during-detaching (issue 595078#c42) which dcheng@ and I fixed last week, but your build looks newer than that.

Comment 4 by amp@chromium.org, Mar 29 2017

Status: Fixed (was: Available)
Finally got around to trying to repro this and wasn't able to (on official builds or my dev builds).  The flags are also on by default for Android now so that wouldn't have been the cause even if it did repro.

Marking as fixed.

Sign in to add a comment