New issue
Advanced search Search tips

Issue 658883 link

Starred by 1 user
Status: Fixed
Owner:
bcwh...@chromium.org
Closed: Oct 2016
Cc:
asvitk...@chromium.org
wittman@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Improve CallStackProfile Efficiency By Using std::move

Project Member Reported by bcwh...@chromium.org, Oct 24 2016 
The data collected by the CallStackProfiler object is copied around several times.  Change this to use std::move instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c851d8622ae32dfb293181be904788b28d2f0d

commit c3c851d8622ae32dfb293181be904788b28d2f0d
Author: bcwhite <bcwhite@chromium.org>
Date: Wed Oct 26 21:20:42 2016

Use movable types for CallStackProfile(s) to remove copying of data.

BUG= 658883 
TBR=jschuh  (for security of unittest)

Review-Url: https://codereview.chromium.org/2438073002
Cr-Commit-Position: refs/heads/master@{#427799}

[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/base/profiler/stack_sampling_profiler.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/base/profiler/stack_sampling_profiler.h
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/base/profiler/stack_sampling_profiler_unittest.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/call_stack_profile_collector.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/call_stack_profile_collector.h
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/call_stack_profile_metrics_provider.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/call_stack_profile_metrics_provider.h
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/call_stack_profile_metrics_provider_unittest.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/child_call_stack_profile_collector.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/child_call_stack_profile_collector.h
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/child_call_stack_profile_collector_unittest.cc
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/public/cpp/call_stack_profile.typemap
[modify] https://crrev.com/c3c851d8622ae32dfb293181be904788b28d2f0d/components/metrics/public/cpp/call_stack_profile_struct_traits_unittest.cc

Comment 2 by bcwh...@chromium.org, Oct 27 2016

Status: Fixed (was: Started)
►

Sign in to add a comment