New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658874 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Background not always painted for composited table cells.

Project Member Reported by wkorman@chromium.org, Oct 24 2016

Issue description

Breakout from  http://crbug.com/647809  and http://crbug.com/656148 -- attached test case illustrates. Hover mouse over 'F', then out of it, then move back in.

wangxianzhu@ believes this may not be a recent regression. I didn't see an immediate existing bug so filing new for tracking.
 
composited-collapsed-table-background.html
569 bytes View Download
Labels: M-55
Initial work aiming to fix produced what looked like an under-invalidation failure, so this bug may also relate to  http://crbug.com/626748 .

**NOTE** this one may warrant M-55 ReleaseBlock-Stable, I have not yet validated that the issue was not present in M53.
Labels: ReleaseBlock-Stable
Adding stable blocking label in case necessary, can remove if determined not applicable.

Comment 3 by gov...@chromium.org, Oct 26 2016

**** Bulk edit -  please ignore if not applicable ****

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Comment 4 by gov...@chromium.org, Oct 31 2016

**** Bulk edit -  please ignore if not applicable ****

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!


This bisects to:

https://chromium.googlesource.com/chromium/src/+log/d50f0b14f31a77d7c18296dde00e54a07687d06b..49cbf7dc7508bec4920ed325afa0b57749795ac1

which includes my change https://codereview.chromium.org/1484163002 which was reverted but then re-landed as https://codereview.chromium.org/1844993002

So confirmed this was a regression in M54 and we should fix for M55.
Note I'm tracking this as a paint team stable regression.
Likely incorrect visual rect for the background of the composited table cell via TableRowPainter::paintBackgroundBehindCell():

{index: 4, client: "0x3073850404f8 LayoutTableCell TD", type: "DrawingTableCellBackgroundFromRow", rect: [69.000000,75.000000 59.000000x67.000000], cacheIsValid: true, visualRect: [0,0 59x68]},
Summary: Background not always painted for composited table cells. (was: Background not always painted for composited border-collapse table cells.)
Note this issue does not require collapsed borders.
https://codereview.chromium.org/2469903002/ is out for review.
Still working on the patch due to one discovered test failure. In paint/invalidation/composited-table-cell-container-background.html we see a case where the *row* is composited as well as the cell. As a result, we use the wrong visual rect (the table's vs. the row's) and we have an under-invalidation. I believe the fix for the patch is:

1. if the cell's containing row is composited then LayoutTableCell::CompositedTableCell::visualRect() should return the row's visual rect rather than the table's

2. in TablePaintInvalidator::invalidatePaintIfNeeded(), in the last case:

        if ((!invalidated || row->hasSelfPaintingLayer()) &&
            row->backgroundChangedSinceLastPaintInvalidation())
          ObjectPaintInvalidator(*row).slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(*cell, PaintInvalidationStyleChange);

we also need to invalidate the CompositedTableCell as:

          invalidator.invalidateDisplayItemClient(*cell->compositedTableCell(), PaintInvalidationStyleChange);

I am trying this now, initial hack looks positive.
**** Bulk edit -  please ignore if not applicable ****

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure all fixes are ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16.
Any update on comment #10?
If patch is ready, please land to trunk ASAP and request a merge to M55 once change is baked/verified in Canary. Thank you
We addressed what's noted in #10 but additional cases to consider came up in the code review.

I won't be able to get back to the change until this Thursday. We know what work needs to be done and it is noted in http://crrev.com/2469903002/ comments. I would estimate a day or two of work, so the change won't land on master until 11/14 or 15. Excerpted, the work is to "[add] special DisplayItemClients for section (for section background) and table (for col, colgroup)."

If that is not soon enough we need to find someone else to finish this up.
If change is landed on master on 11/14 or 15 is fine. Thank you.
Hi there, I am looking at this again now and will try to land by 11/15.
Ok, sounds good. Thank you. 
wangxianzhu@: I'm having trouble creating a test case for composited table sections that fails with http://crrev.com/2469903002.

I've created ones that fail for colgroup, col, and col w/ span.

Attached are current tests including the section one for reference.

Is it possible that the visual rect for the LayoutTableRow will always be valid for use with section's graphics layer when we're painting a section, even when the LayoutTableSection has its own composited layer? I can't disprove.

If that *is* true then, for the section background painting case, we can use the row's visual rect, and invalidate a smaller rect.

But you are correct that col/colgroup were broken with patch and I am working on an update now.
composited-table-background-section.html
718 bytes View Download
composited-table-background-col.html
602 bytes View Download
composited-table-background-colgroup.html
618 bytes View Download
composited-table-background-col-span.html
642 bytes View Download
OK, the attached revised section test produces an incorrect visual rect for the row background painting for the section, as we make the row itself also composited:

{index: 4, client: "0x3255b15321a0 RowBackground", type: "DrawingTableCellBackgroundFromSection", rect: [64.000000,68.000000 59.000000x64.000000], cacheIsValid: true, visualRect: [0,0 186x64]},

(x,y) is (0,0) where it should be non-zero as we paint the background on the section's layer and the cell in question is in the second row.

However, it still paints correctly. How to make it fail?

composited-table-background-section.html
628 bytes View Download
**** Bulk edit -  please ignore if not applicable ****


A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure fix is ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16 (sooner the better).
Cc: ranjitkan@chromium.org
@wkorman: Gentle ping, can we have an update on the issue. Issue is marked with a stable blocker and M55 is going to be pushed to stable soon.

Thanks.!
After discussion on https://codereview.chromium.org/2469903002/ we decided to go back to an earlier version of that patch, roughly patchset 8. I am preparing that change now. It could land today or tomorrow.

Rationale -- it will be a small change easier to merge, focused on the most common case we see failing in this bug -- a composited cell in a non-composited row. We'll explore alternate approach outside of M55-blocking for fuller fix.

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8fded973e0422c68dd85f3745b26a0a8d96085

commit 9c8fded973e0422c68dd85f3745b26a0a8d96085
Author: wkorman <wkorman@chromium.org>
Date: Thu Nov 17 01:50:59 2016

Fix painting background for composited table cells in a non-composited row.

Use a background specific display item client and the LayoutTableRow's
visual rect.

BUG= 658874 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2507893002
Cr-Commit-Position: refs/heads/master@{#432693}

[modify] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.png
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.txt
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section.html
[add] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background.html
[modify] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/9c8fded973e0422c68dd85f3745b26a0a8d96085/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

Labels: Merge-Request-55
Status: Fixed (was: Started)
Mac Canary 56.0.2923.0 has the above change in it. Requesting test team verification and then merge to M55. Doing both in this one bug update in the interest of expediency.
For test team, original repro steps can follow the original steps in http://crbug.com/656148 or my reduction in c#5 of that bug.
Thank you  wkorman@, Verified the fix with Chrome 56.0.2923.0 on Mac(retina Display) with reduction steps provided in bug http://crbug.com/656148#c5 :

When hover mouse over "Untitled project", then out of it and then move back in "Untitled project" I see the complete thing gets focused.

Note : I am not marking the bug as Verified since we need to merge the fix to M55.
We expect this to be a safe merge, low risk of introducing other regression. Fix is focused on table cell paint logic. We've run the change through ct.skia.org benchmarking on top 10k sites, note from wangxianzhu@ results below copied from discussion on above change for posterity.

On 2016/11/17 07:17:58, Xianzhu wrote:
> Here are statistics of composited table component backgrounds
> (https://ct.skia.org/chromium_perf_runs/ run 1466):
> - Total cells: 514,873
>   Composited cells: 1,082
>   Composited cells, in any row/section/col with background: 27
> - Total rows: 367,275
>   Composited rows: 33
>   Composited rows, in any section with background, or intersecting any col
with
> background: 0
> - Total sections: 320,503
>   Composited sections: 28
>   Composited sections, intersecting any col with background: 0
> 
> The cases of composited rows and sections are very rare, and there is no
single
> case breaking this CL.
Approving merge to M55 branch 2883 based on comment #25, #26 and per chat with  wkorman@. Please merge ASAP. Thank you.
Looks like auto approval script & I were updating bug at same time. Because of that my update at #27 not showing removal of "Merge-Request-55" label and adding "Merge-Approved-55" label.
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 18 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4fdf5cba5c295b1702bad390bd999b9f0be0503

commit b4fdf5cba5c295b1702bad390bd999b9f0be0503
Author: Walter Korman <wkorman@chromium.org>
Date: Fri Nov 18 02:45:01 2016

Fix painting background for composited table cells in a non-composited row.

Use a background specific display item client and the LayoutTableRow's
visual rect.

BUG= 658874 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2507893002
Cr-Commit-Position: refs/heads/master@{#432693}
(cherry picked from commit 9c8fded973e0422c68dd85f3745b26a0a8d96085)

Review URL: https://codereview.chromium.org/2515573002 .

Cr-Commit-Position: refs/branch-heads/2883@{#604}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.png
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.txt
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section.html
[add] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background.html
[modify] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/Source/core/layout/LayoutTableCell.h
[modify] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99

commit d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Fri Nov 18 03:55:00 2016

Auto-rebaseline for r432693

https://chromium.googlesource.com/chromium/src/+/9c8fded97

BUG= 658874 
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2510023003 .

Cr-Commit-Position: refs/heads/master@{#433084}

[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-initial-empty-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-initial-empty-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-expected.txt
[modify] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/paint/invalidation/table/composited-table-background-section-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-span-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-span-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-colgroup-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-colgroup-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-composited-row-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-composited-row-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-composited-row-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-composited-row-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-expected.txt
[rename] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/table/composited-table-background-section-initial-empty-expected.txt
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-col-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-col-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-col-span-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-colgroup-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-composited-row-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-section-composited-row-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-section-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/composited-table-background-section-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-col-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-col-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-col-span-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-col-span-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-colgroup-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-colgroup-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-composited-row-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-composited-row-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-section-composited-row-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-section-composited-row-initial-empty-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-section-expected.png
[add] https://crrev.com/d0f6747c2dbfa26656b4ad1fc883b4e6d8c91c99/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/composited-table-background-section-initial-empty-expected.png

Labels: TE-Verified-55.0.2883.59 TE-Verified-M55
Rechecked this on chrome version 55.0.2993.59 on MAC Retina Pro 10.12.1 with reduction steps provided in bug http://crbug.com/656148#c5 and also using the steps mentioned in https://bugs.chromium.org/p/chromium/issues/detail?id=656148#c2. Fix is working as intended. Cell border, background are displaying as required.

Adding TE-verified labels.

Thanks.!

Sign in to add a comment