New issue
Advanced search Search tips

Issue 658860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

PolicyTest.EnabledPlugins PolicyTest.DisabledPluginsExceptions PolicyTest.DisabledPlugins broken in official builds

Project Member Reported by thakis@chromium.org, Oct 24 2016

Issue description

Started here:

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/48038

I bet it's due to pastarmovj's change. cc'ing waffles since bug 641884 sounds a bit similar.

Also broken e.g. on https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20trunk/ so not win-only.
 
Yes seems like its my change. I will investigate why these tests fail on the official builders.
Status: Started (was: Assigned)
My bad I didn't catch those tests because they only ever check something on the official builds. They are obsolete however because the policies they check have been deprecated and the deprecation logic is tested elsewhere.

I will remove them asap.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f091f28ea395ee7486b3c2c9a493c1fe38908dda

commit f091f28ea395ee7486b3c2c9a493c1fe38908dda
Author: pastarmovj <pastarmovj@chromium.org>
Date: Tue Oct 25 15:58:05 2016

Remove obsolete plugin-related policies browsertests.

Those tests were checking obsolete and deprecated behaviour. They were
only caught on the official builders because they were noops on Chromium
builds.

BUG= 658860 
TEST=Official builders turn green.

Review-Url: https://codereview.chromium.org/2448033004
Cr-Commit-Position: refs/heads/master@{#427369}

[modify] https://crrev.com/f091f28ea395ee7486b3c2c9a493c1fe38908dda/chrome/browser/policy/policy_browsertest.cc

Comment 4 by thakis@chromium.org, Oct 25 2016

Status: Fixed (was: Started)
Thanks!

Sign in to add a comment