Harmony - update Translate 2016Q2 dialog |
|||||||||||||
Issue descriptionSee attached video. Text shadow appears and vanishes on hover of button
,
Oct 24 2016
That button is not a harmony control. That button cannot easily be updated to a harmony control because of the weird downward pointing arrow on the right. We're still waiting on the translate team to figure out what UI they're moving forward with.
,
Oct 25 2016
zkoch@ - redesign of the translate bubble is/has been underway? Is there a flag to access the new translate UI?
,
Oct 30 2016
Yes, the flag for the new translate UI is "Translate2016" or something like that. A search will reveal the right one. But note that this does redesign is *not* the Harmony redesign. I think it has the same control. As of right now, we have no one staffed to update to the harmony control style.
,
Oct 31 2016
Searching for Translate2016 does not match a flag in the code, and searching for "translate" or "2016" does not match a flag on the chrome://flags page. Last I remember the translate UI was being changed to get rid of the strange dropdown/button control - is that still happening (and can you point me at design docs again)? As long as translate starts using a standard control it should pick up the Harmony changes.
,
Oct 31 2016
Re: the flag, are you looking at Windows or Mac? Mac it's "New Translate UX". On Windows, I can't remember exactly, but searching for translate should definitely bring it up. Regarding the design, +hwi to talk about that. I know there is back and forth with the Translate team.
,
Oct 31 2016
Thanks for the info. I looked at the dialog on Windows - it does not use the funky dropdown-button control, but it does use a "MenuButton" instead of what Views calls a combobox, which is why it isn't picking up the Harmony styling. The fix should be to just change the control to a combobox.
,
Oct 31 2016
For the *next* new translation UI, we're going in a direction with just a regular button for "Options": this is currently at design stage.
,
Jan 24 2017
Per shrike, unassigning his Harmony bugs for now.
,
Jan 26 2017
I tried to retitle to reflect comment 7. zkoch/hwi -- is the new title accurate (would address the issue here and is the thing we want to do in the short term), and should this be tracked under the Harmony dialogs work? I'm trying to make this bug actionable and figure out what's in scope vs. out of scope for Harmony phase 1.
,
Jan 26 2017
Hwi, can you share current state of Translate for Harmony? I wonder if it makes sense to close out this bug and file a new one with the new mocks?
,
Jan 26 2017
It's out of scope for Harmony phase 1. It's a weird bug name, but, it should be marked as "Do not harmonize for Phase 1". Translate+Harmony intends to change all controls and UI states and is nearing UI review. It doesn't have the combobox button any more. Once the UI review signs off, we can create a new bug.
,
Mar 29 2017
We have mocks for the Harmony version of Translate 2016Q2 now: https://folio.googleplex.com/chrome-ux/mocks/413-translate-harmony/2017-revamp-plan#%2FTranslate%20Revamp%20Plan%202017.png so I'm repurposing this bug and also I'll do a pass on the dialog.
,
Apr 5 2017
Issue 619191 has been merged into this issue.
,
Apr 6 2017
Issue 701460 has been merged into this issue.
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb91c5093e7b44830872d79d95d4c391c82776b8 commit bb91c5093e7b44830872d79d95d4c391c82776b8 Author: tapted <tapted@chromium.org> Date: Thu May 25 01:31:45 2017 Layout the translate bubble after changing child view visibility. BoxLayout only manipulates visible subviews, so making a subview newly visible may require a layout. A SizeToContents() call can also trigger Layout() but only if the size of the Widget actually changes. r466211 removed some unnecessary insets such that this was no longer likely for a particular translate bubble UI transition. BUG= 721213 , 658854 TEST=(see bug) On Windows, set flags: - chrome://flags/#translate-2016q2-ui Disabled. - chrome://flags/#secondary-ui-md Enabled. Go to a page that needs translating and translate it. Ensure the "Show original" button is positioned in the bottom-right and clickable. Review-Url: https://codereview.chromium.org/2898633004 Cr-Commit-Position: refs/heads/master@{#474511} [modify] https://crrev.com/bb91c5093e7b44830872d79d95d4c391c82776b8/chrome/browser/ui/views/translate/translate_bubble_view.cc
,
Aug 9 2017
,
Aug 9 2017
,
Aug 9 2017
Marking this bug as won't fix since 2016Q2UI won't launch. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bettes@chromium.org
, Oct 24 2016