New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658854 link

Starred by 9 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Harmony - update Translate 2016Q2 dialog

Project Member Reported by bettes@chromium.org, Oct 24 2016

Issue description

See attached video. Text shadow appears and vanishes on hover of button
 
IMG_0089.mov
5.3 MB Download

Comment 1 by bettes@chromium.org, Oct 24 2016

On Canary 56.0.2899.0

Comment 2 by est...@chromium.org, Oct 24 2016

Owner: shrike@chromium.org
That button is not a harmony control. That button cannot easily be updated to a harmony control because of the weird downward pointing arrow on the right. We're still waiting on the translate team to figure out what UI they're moving forward with.

Comment 3 by shrike@chromium.org, Oct 25 2016

Cc: zkoch@chromium.org
Labels: OS-Linux OS-Windows
zkoch@ - redesign of the translate bubble is/has been underway? Is there a flag to access the new translate UI?

Comment 4 by zkoch@chromium.org, Oct 30 2016

Yes, the flag for the new translate UI is "Translate2016" or something like that. A search will reveal the right one. But note that this does redesign is *not* the Harmony redesign. I think it has the same control. As of right now, we have no one staffed to update to the harmony control style.

Comment 5 by shrike@chromium.org, Oct 31 2016

Searching for Translate2016 does not match a flag in the code, and searching for "translate" or "2016" does not match a flag on the chrome://flags page.

Last I remember the translate UI was being changed to get rid of the strange dropdown/button control - is that still happening (and can you point me at design docs again)? As long as translate starts using a standard control it should pick up the Harmony changes.

Comment 6 by zkoch@chromium.org, Oct 31 2016

Cc: hwi@chromium.org
Re: the flag, are you looking at Windows or Mac? Mac it's "New Translate UX". On Windows, I can't remember exactly, but searching for translate should definitely bring it up.

Regarding the design, +hwi to talk about that. I know there is back and forth with the Translate team. 

Comment 7 by shrike@chromium.org, Oct 31 2016

Labels: M-57
Thanks for the info. I looked at the dialog on Windows - it does not use the funky dropdown-button control, but it does use a "MenuButton" instead of what Views calls a combobox, which is why it isn't picking up the Harmony styling. The fix should be to just change the control to a combobox.

Comment 8 by hwi@google.com, Oct 31 2016

For the *next* new translation UI, we're going in a direction with just a regular button for "Options": this is currently at design stage. 
Owner: ----
Status: Available (was: Assigned)
Per shrike, unassigning his Harmony bugs for now.
Summary: Harmony - translate UI should use combobox instead of menu button (was: Text shadow appears on hover of textButton)
I tried to retitle to reflect comment 7.  zkoch/hwi -- is the new title accurate (would address the issue here and is the thing we want to do in the short term), and should this be tracked under the Harmony dialogs work?  I'm trying to make this bug actionable and figure out what's in scope vs. out of scope for Harmony phase 1.

Comment 11 by zkoch@chromium.org, Jan 26 2017

Hwi, can you share current state of Translate for Harmony? I wonder if it makes sense to close out this bug and file a new one with the new mocks?

Comment 12 by hwi@chromium.org, Jan 26 2017

It's out of scope for Harmony phase 1. It's a weird bug name, but, it should be marked as "Do not harmonize for Phase 1". Translate+Harmony intends to change all controls and UI states and is nearing UI review. It doesn't have the combobox button any more. Once the UI review signs off, we can create a new bug. 

Comment 13 by bsep@chromium.org, Mar 29 2017

Owner: bsep@chromium.org
Summary: Harmony - update Translate 2016Q2 dialog (was: Harmony - translate UI should use combobox instead of menu button)
We have mocks for the Harmony version of 
Translate 2016Q2 now: https://folio.googleplex.com/chrome-ux/mocks/413-translate-harmony/2017-revamp-plan#%2FTranslate%20Revamp%20Plan%202017.png so I'm repurposing this bug and also I'll do a pass on the dialog.
Cc: groby@chromium.org pendar@google.com est...@chromium.org ftang@chromium.org pkasting@chromium.org yyushkina@chromium.org
 Issue 619191  has been merged into this issue.
Cc: reg@google.com nyerramilli@chromium.org tkonch...@chromium.org
Issue 701460 has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb91c5093e7b44830872d79d95d4c391c82776b8

commit bb91c5093e7b44830872d79d95d4c391c82776b8
Author: tapted <tapted@chromium.org>
Date: Thu May 25 01:31:45 2017

Layout the translate bubble after changing child view visibility.

BoxLayout only manipulates visible subviews, so making a subview newly
visible may require a layout.

A SizeToContents() call can also trigger Layout() but only if the size
of the Widget actually changes. r466211 removed some unnecessary insets
such that this was no longer likely for a particular translate bubble
UI transition.

BUG= 721213 ,  658854 
TEST=(see bug) On Windows, set flags:
 - chrome://flags/#translate-2016q2-ui Disabled.
 - chrome://flags/#secondary-ui-md Enabled.
Go to a page that needs translating and translate it. Ensure the
"Show original" button is positioned in the bottom-right and clickable.

Review-Url: https://codereview.chromium.org/2898633004
Cr-Commit-Position: refs/heads/master@{#474511}

[modify] https://crrev.com/bb91c5093e7b44830872d79d95d4c391c82776b8/chrome/browser/ui/views/translate/translate_bubble_view.cc

Labels: -M-57
Labels: -Pri-2 Pri-1
Status: Assigned (was: Available)
Status: WontFix (was: Assigned)
Marking this bug as won't fix since 2016Q2UI won't launch.

Sign in to add a comment