New issue
Advanced search Search tips

Issue 658833 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add Google Privacy Policy link into Arc OptIn UI

Project Member Reported by khmel@chromium.org, Oct 24 2016

Issue description

Inner bug: b/30103177

CLs:
http://crrev.com/2429793003
http://crrev.com/2434823002

This is M55 Blocker.

Requesting to merge.
 
Labels: -Merge-Request-55 Merge-Approved-55
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365114871c27be85ba673dd44bb81d97d87c378b

commit 365114871c27be85ba673dd44bb81d97d87c378b
Author: khmel <khmel@chromium.org>
Date: Fri Oct 28 21:42:14 2016

[Merge-M55] arc: Use overlay to show links from ToS.

BUG=b/32247410
BUG= 658833 
TEST=Locally on device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2429793003
Cr-Commit-Position: refs/heads/master@{#426101}
(cherry picked from commit 845e02dc39e9283f6a13957bac034c0d4a3d172c)

Review-Url: https://codereview.chromium.org/2458213002
Cr-Commit-Position: refs/branch-heads/2883@{#362}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/365114871c27be85ba673dd44bb81d97d87c378b/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/365114871c27be85ba673dd44bb81d97d87c378b/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/365114871c27be85ba673dd44bb81d97d87c378b/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/365114871c27be85ba673dd44bb81d97d87c378b/chrome/browser/resources/chromeos/arc_support/main.html

Comment 3 by khmel@chromium.org, Oct 28 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6117ed9760983f3627e991d99bb3e2e441a8ffb

commit a6117ed9760983f3627e991d99bb3e2e441a8ffb
Author: khmel <khmel@chromium.org>
Date: Fri Oct 28 22:05:02 2016

[Merge-M55] arc: Add Goolge Privacy Policy link to OptIn UI.

This adds a link to GetStarted page that opens Privacy Policy for
the language currently selected in ToS

BUG=b/30103177
BUG= 658833 
TEST=Locally on device.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://chromiumcodereview.appspot.com/2434823002
Cr-Commit-Position: refs/heads/master@{#426288}
(cherry picked from commit 06650954785fb597dba01d710db0a8665206e647)

Review-Url: https://codereview.chromium.org/2460933003
Cr-Commit-Position: refs/branch-heads/2883@{#365}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/a6117ed9760983f3627e991d99bb3e2e441a8ffb/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/a6117ed9760983f3627e991d99bb3e2e441a8ffb/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/a6117ed9760983f3627e991d99bb3e2e441a8ffb/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/a6117ed9760983f3627e991d99bb3e2e441a8ffb/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/a6117ed9760983f3627e991d99bb3e2e441a8ffb/chrome/browser/resources/chromeos/arc_support/playstore.js

Status: Verified (was: Fixed)
Verified on 55.0.2883.34/8872.34.0

Sign in to add a comment