New issue
Advanced search Search tips

Issue 658830 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Auth code on demand in broken.

Project Member Reported by khmel@chromium.org, Oct 24 2016

Issue description

Existing flow to request auth code on demand is broken.

There is inner bug for this: b/32124104

Following CL fixes this:
http://crrev.com/2412133004

It is marked as M55 blocker.
Requesting to merge.
 
Labels: -Merge-Request-55 Merge-Approved-55
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a37dd463189340a16737dcddcc037e6564f3ac7

commit 0a37dd463189340a16737dcddcc037e6564f3ac7
Author: khmel <khmel@chromium.org>
Date: Wed Oct 26 00:36:27 2016

[Merge-M55] arc: Restore broken auth code request on demand.

This feature is required when Android needs re-authorization
or in new OOBE Arc Terms integration.

BUG=b/32124104
BUG= 658830 
TEST=Manually on device during the testing OOBE Arc Terms

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

(cherry picked from commit b5454c4d0b19707cf4f072af7c54f6f2f2695f83)

Review-Url: https://chromiumcodereview.appspot.com/2412133004
Review-Url: https://codereview.chromium.org/2454533002
Cr-Original-Commit-Position: refs/heads/master@{#426680}
Cr-Commit-Position: refs/branch-heads/2883@{#306}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/0a37dd463189340a16737dcddcc037e6564f3ac7/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/0a37dd463189340a16737dcddcc037e6564f3ac7/chrome/browser/chromeos/arc/arc_auth_service.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a37dd463189340a16737dcddcc037e6564f3ac7

commit 0a37dd463189340a16737dcddcc037e6564f3ac7
Author: khmel <khmel@chromium.org>
Date: Wed Oct 26 00:36:27 2016

[Merge-M55] arc: Restore broken auth code request on demand.

This feature is required when Android needs re-authorization
or in new OOBE Arc Terms integration.

BUG=b/32124104
BUG= 658830 
TEST=Manually on device during the testing OOBE Arc Terms

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

(cherry picked from commit b5454c4d0b19707cf4f072af7c54f6f2f2695f83)

Review-Url: https://chromiumcodereview.appspot.com/2412133004
Review-Url: https://codereview.chromium.org/2454533002
Cr-Original-Commit-Position: refs/heads/master@{#426680}
Cr-Commit-Position: refs/branch-heads/2883@{#306}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/0a37dd463189340a16737dcddcc037e6564f3ac7/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/0a37dd463189340a16737dcddcc037e6564f3ac7/chrome/browser/chromeos/arc/arc_auth_service.h

Comment 4 by khmel@chromium.org, Oct 28 2016

Status: Fixed (was: Started)

Comment 5 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 6 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Status: Verified (was: Fixed)

Sign in to add a comment