New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658829 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Deleting a downloaded file in Chrome doesn't delete the pointer from Android Downloads

Project Member Reported by dah...@chromium.org, Oct 24 2016

Issue description

(1)STEPS TO REPRODUCE:
1.Download a photo from the Internet using Chrome
2.Make sure Photos includes the Android Downloads folder as a target
3.View the downloaded photo in Photos
4.Delete the Photo from the Chrome Download manager (requires Chrome M54 Beta or later). 
5.View the downloaded photo that is still available in Photos
6.Restart photos
7.View the downloaded photo in Photos which is now a grey box
8.Open the grey box photo, Photos crashes
9. Open Android Downloads app, the photo is still available
10. View the photo in Android Downloads app, the photo is just blank.

EXPECTED RESULTS:
Once the photo is deleted from Chrome, it should no longer appear in the Android Downloads app or Photos app.

OBSERVED RESULTS:
After the photo is deleted from Android, it can still be see in the Photos app. After Photos is restarted the photo is replaced by a grey box. Trying to open the file causes photos to crash.

Android 7.0 
Nexus 6 device
Photos version 2.2.1.136513178

 
Cc: dfalcant...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b318140c9474e8e133bf3a403e94e7569c9bd4cd

commit b318140c9474e8e133bf3a403e94e7569c9bd4cd
Author: qinmin <qinmin@chromium.org>
Date: Fri Oct 28 21:18:58 2016

Delete download in Android DownloadManager when download is deleted from download home

This change adds a SharedPreference file to map download GUIDs to android download Ids.
When a download is removed from download home, also remove it from Android DM.

BUG= 658829 

Review-Url: https://codereview.chromium.org/2456593002
Cr-Commit-Position: refs/heads/master@{#428495}

[modify] https://crrev.com/b318140c9474e8e133bf3a403e94e7569c9bd4cd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java
[modify] https://crrev.com/b318140c9474e8e133bf3a403e94e7569c9bd4cd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 3 by qin...@chromium.org, Oct 28 2016

Labels: Merge-Request-55

Comment 4 by dimu@chromium.org, Oct 28 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcba1820e2fd8a7e26dc36104350177623415610

commit bcba1820e2fd8a7e26dc36104350177623415610
Author: Min Qin <qinmin@chromium.org>
Date: Mon Oct 31 19:46:37 2016

Delete download in Android DownloadManager when download is deleted from download home

This change adds a SharedPreference file to map download GUIDs to android download Ids.
When a download is removed from download home, also remove it from Android DM.

TBR=dfalcantara@chromium.org
BUG= 658829 

Review-Url: https://codereview.chromium.org/2456593002
Cr-Commit-Position: refs/heads/master@{#428495}
(cherry picked from commit b318140c9474e8e133bf3a403e94e7569c9bd4cd)

Review URL: https://codereview.chromium.org/2466683002 .

Cr-Commit-Position: refs/branch-heads/2883@{#391}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/bcba1820e2fd8a7e26dc36104350177623415610/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java
[modify] https://crrev.com/bcba1820e2fd8a7e26dc36104350177623415610/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Comment 6 by qin...@chromium.org, Oct 31 2016

Status: Fixed (was: Assigned)
Verified in M55 -55.0.2883.36

Sign in to add a comment