New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658821 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Dec 2016
Cc:
dbeam@chromium.org
█ tsergeant@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove cr-shared-menu, replace usage with settings-action-menu.

Project Member Reported by dpa...@chromium.org, Oct 24 2016 
cr-shared-menu usage in MD Settings has now been replaced by a new settings-aciton-menu element which is implemented as a native <dialog>. This addresses several issues that cr-shared-menu has (https://bugs.chromium.org/p/chromium/issues/detail?id=639718).

cr-shared-menu is now used only by MD History. I propose to
1) promote settings-action-menu to a shared cr-action-menu element,
2) Migrate MD History to use it
3) Remove cr-shared-menu completely.

Comment 1 by dpa...@chromium.org, Oct 29 2016

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fced7253587914664c2cfec0380198dc328767c4

commit fced7253587914664c2cfec0380198dc328767c4
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 02 20:38:37 2016

WebUI: Make settings-action-menu re-usable as cr-action-menu.

BUG= 658821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2461113002
Cr-Commit-Position: refs/heads/master@{#429388}

[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/certificate_manager_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/printing_page/cups_printers_list.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/browser/resources/settings/site_settings/site_list.js
[rename] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/chrome/test/data/webui/settings/startup_urls_page_test.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/ui/webui/resources/cr_elements/compiled_resources2.gyp
[add] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/ui/webui/resources/cr_elements/cr_action_menu/compiled_resources2.gyp
[rename] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
[rename] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
[modify] https://crrev.com/fced7253587914664c2cfec0380198dc328767c4/ui/webui/resources/cr_elements_resources.grdp
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407

commit 8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407
Author: dpapad <dpapad@chromium.org>
Date: Thu Dec 22 01:51:50 2016

MD History: Replace last usage of cr-shared-menu with cr-action-menu.

 - Remove logic to close menu when scrolling (no longer possible since
   cr-action-menu is a modal <dialog>).
 - Replace "toggle" logic with simpler "open" logic (the menu button can't
   be clicked when the menu is open.
 - Simplify tests that were testing impossible scenarios (open-menu event
   can't fire for a different history entry, while the menu is already open).

BUG= 658821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2583353003
Cr-Commit-Position: refs/heads/master@{#440308}

[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/lazy_load.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/synced_device_card.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/test/data/webui/md_history/history_overflow_menu_test.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/8630d3b2a1d2039ec3b2734bc5bebc2d91ec1407/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Comment 4 by dpa...@chromium.org, Dec 22 2016

Status: Fixed (was: Started)
Somehow bugdroid did not update the bug with the final CL, https://codereview.chromium.org/2594183002.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4

commit 8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Dec 28 00:41:33 2016

MD History: Fix broken sync status dropdown

The sync (i) icon in the top-right of the page uses the iron-dropdown
Polymer element to display its content. This element was implicitly
imported by cr-shared-menu, meaning that after cr-shared-menu was
removed (in crrev.com/440308) from the history page, the dropdown
stopped working.

This CL restores the import of iron-dropdown, fixing the dropdown.

BUG= 658821 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2594303002
Cr-Commit-Position: refs/heads/master@{#440815}

[modify] https://crrev.com/8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4/chrome/browser/resources/md_history/lazy_load.html
[modify] https://crrev.com/8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4/chrome/browser/resources/md_history/lazy_load.vulcanized.html
►

Sign in to add a comment