New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658795 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Oct 2016
Cc:
█ zakerinasab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 474273



Sign in to add a comment

rebaseline-cl --only-changed-tests doesn't include any tests on Windows.

Project Member Reported by qyears...@chromium.org, Oct 24 2016 
In https://codereview.chromium.org/2427773002/, when zakerinasab@ invoked webkit-patch rebaseline-cl --only-changed-tests, it didn't find any tests to rebaseline, even though there is a test to rebaseline; when invoked without --only-changed-tests, it found the test to rebaseline (in addition to some other tests which shouldn't be rebaselined).

Hypothesis: rebaseline-cl is using WebKitFinder.layout_test_name to determine whether a file in the CL is a layout test, and this method always returns None on Windows, since it doesn't properly handle file paths on Windows.

This bug is currently not straightforward to reproduce in unit tests since some other functions in MockFileSystem and MockSCM may assume that paths are Unix-style paths.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2774ec5c145d28382c52bf3a625c3bd212d1b83c

commit 2774ec5c145d28382c52bf3a625c3bd212d1b83c
Author: qyearsley <qyearsley@chromium.org>
Date: Tue Oct 25 23:24:02 2016

Fix for rebaseline-cl --only-changed-tests: use hard-coded constant layout test dir.

This is meant to be a quick fix so that rebaseline-cl can get the list of changed tests correctly regardless of what the user's OS is ( http://crbug.com/658795 ).

This CL adds a couple of TODO notes where I think I should make follow-up CLs.

BUG= 658795 

Review-Url: https://codereview.chromium.org/2442273003
Cr-Commit-Position: refs/heads/master@{#427530}

[modify] https://crrev.com/2774ec5c145d28382c52bf3a625c3bd212d1b83c/third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py
[modify] https://crrev.com/2774ec5c145d28382c52bf3a625c3bd212d1b83c/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Comment 2 by qyears...@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)
Submitted workaround, so I think it should work now, so I'll mark this particular bug as fixed -- but I filed  bug 660064  to follow up with my TODO note.
►

Sign in to add a comment