New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658792 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 658544



Sign in to add a comment

Do not schedule slaves when CQ-master has no CLs to test

Project Member Reported by nxia@chromium.org, Oct 24 2016

Issue description

If no CLs need to be tested, CQ will spend hours (~7 hours) syncing and waiting for CLs. In this case, master should just complete without committing manifest-versions messages or scheduling slave builds, as most slave builds will time out.

https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/12685 

https://uberchromegw.corp.google.com/i/chromeos/builders/master-paladin/builds/12687

 

Comment 1 by dshi@chromium.org, Oct 25 2016

Owner: nxia@chromium.org
Status: Assigned (was: Untriaged)
nxia, is this something you know how to fix? Or talk to Don about the fix.

Comment 2 by nxia@chromium.org, Oct 25 2016

Blocking: 658544

Comment 3 by nxia@chromium.org, Oct 25 2016

Issue 658544 has been merged into this issue.
Labels: -Pri-3 Pri-2
Raising priority as this can cause sheriffs to panic and waste their time and that of other people.

Comment 5 by nxia@chromium.org, Feb 2 2017

Labels: Hotlist-Fixit

Comment 6 by nxia@chromium.org, Feb 6 2017

Labels: cros-infra-fixedit-q117
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/36c62885bc723cbe5b038e8624d61da778da4b3c

commit 36c62885bc723cbe5b038e8624d61da778da4b3c
Author: Ningning Xia <nxia@chromium.org>
Date: Mon Feb 06 22:50:34 2017

Skip scheduling slave builds when no CLs to test.

Do not schedule slaves when CQ-master build doesn't find any CLs to test
in a run.

BUG= chromium:658792 
TEST=unit_test

Change-Id: I2c0fd9f39353c5a3011f35a0d6194ea481611b03
Reviewed-on: https://chromium-review.googlesource.com/435893
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/36c62885bc723cbe5b038e8624d61da778da4b3c/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/36c62885bc723cbe5b038e8624d61da778da4b3c/cbuildbot/stages/scheduler_stages_unittest.py
[modify] https://crrev.com/36c62885bc723cbe5b038e8624d61da778da4b3c/lib/config_lib.py
[modify] https://crrev.com/36c62885bc723cbe5b038e8624d61da778da4b3c/cbuildbot/builders/simple_builders.py

Comment 8 by nxia@chromium.org, Feb 6 2017

Status: Fixed (was: Assigned)

Sign in to add a comment