New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658757 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in SkPath::transform

Project Member Reported by ClusterFuzz, Oct 24 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5009632272842752

Fuzzer: inferno_twister
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 1
Crash Address: 0x7b5000008ecd
Crash State:
  SkPath::transform
  SkClipStack::clipPath
  SkCanvas::onClipPath
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=411529:411868

Minimized Testcase (7.09 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94htajsulXFbY8i50aamLMGLKw6pYgbVHDlsSUqHVrOQRd0Xi95FpdEKpuFp8ybr05CUCxmcNt2UBIRpdwEqsXUFZZs-mkgT2dZKPpKuJALFp4MXNXxc6d91VcrlPDBjgOL_iblE3dITuFe6p2wAD6djuXzhA?testcase_id=5009632272842752

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Internals>Skia
Labels: M-55 Te-Logged
Owner: msarett@chromium.org
Status: Assigned (was: Untriaged)
Author: msarett
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/fbfa25802709139c2f14e304319c9541da65ca27
Time: Fri Aug 12 15:29:08 2016
Lines 1597 of file SkCanvas.cpp which potentially caused crash are changed in this cl (frame #3, "SkCanvas::clipPath").
Minimum distance from crash line to modified line: 0. (file: SkCanvas.cpp, crashed on: 1597, modified: 1597).

Suspected Project: chromium-skia
Suspected Component: Internals>Skia
Cc: msarett@chromium.org
Owner: caryclark@chromium.org
Cary, does this mean anything to you?  I *think* the blame is bogus and I'm not too familiar with this code.
Owner: mtklein@chromium.org
The problem is a race condition with SkPath::getConvexity(). 
This periodically shows up in the Skia bots as well.
Project Member

Comment 4 by ClusterFuzz, Nov 4 2016

ClusterFuzz has detected this issue as fixed in range 429544:429546.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5009632272842752

Fuzzer: inferno_twister
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Data race READ 1
Crash Address: 0x7b5000008ecd
Crash State:
  SkPath::transform
  SkClipStack::clipPath
  SkCanvas::onClipPath
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=411529:411868
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_tsan_chrome_mp&range=429544:429546

Minimized Testcase (7.09 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94htajsulXFbY8i50aamLMGLKw6pYgbVHDlsSUqHVrOQRd0Xi95FpdEKpuFp8ybr05CUCxmcNt2UBIRpdwEqsXUFZZs-mkgT2dZKPpKuJALFp4MXNXxc6d91VcrlPDBjgOL_iblE3dITuFe6p2wAD6djuXzhA?testcase_id=5009632272842752

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 4 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment