We have LGTM from UI Review on our proposal to add a search behavior to downloads home: https://docs.google.com/presentation/d/1dFz09wgzykFM-_-XZh9PKDbTLAz_HDKVgPBMGCEASZA/edit#slide=id.g1781ef71a3_0_205 Please request additional specs if needed.
-> Theresa because of the history page rewrite.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02e089f068c6aef4fb7341e9502211f953406ff2 commit 02e089f068c6aef4fb7341e9502211f953406ff2 Author: twellington <twellington@chromium.org> Date: Fri Jan 20 22:39:37 2017 [Downloads UI] Implement search Adds search functionality for the downloads UI. Also refactors code that is shared with the history UI into the super classes both UIs rely on. BUG= 658750 Review-Url: https://codereview.chromium.org/2640333003 Cr-Commit-Position: refs/heads/master@{#445190} [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/res/layout/bookmark_main_content.xml [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/res/layout/download_manager_toolbar.xml [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/res/layout/history_toolbar.xml [add] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/res/layout/search_toolbar.xml [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/res/menu/download_manager_menu.xml [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/BackendItems.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java [add] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java [delete] https://crrev.com/6e0635ee33f5876d1735a5a49ff88fba5366e245/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectionToolbar.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/java_sources.gni [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java [modify] https://crrev.com/02e089f068c6aef4fb7341e9502211f953406ff2/tools/metrics/actions/actions.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bdaf1a29b43e5b4186b8848df19758b3d21b7aa commit 6bdaf1a29b43e5b4186b8848df19758b3d21b7aa Author: twellington <twellington@chromium.org> Date: Tue Jan 31 18:41:40 2017 [Downloads UI] End search on filter change BUG= 658750 Review-Url: https://codereview.chromium.org/2668013002 Cr-Commit-Position: refs/heads/master@{#447279} [modify] https://crrev.com/6bdaf1a29b43e5b4186b8848df19758b3d21b7aa/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
Comment 1 by dfalcant...@chromium.org
, Oct 24 2016Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)