New issue
Advanced search Search tips

Issue 658749 link

Starred by 3 users
Status: Fixed
Owner:
tkent@chromium.org
Closed: Dec 2016
Cc:
tkent@chromium.org
esprehn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove (Unicode) case-insensitive matching for radio button groups

Project Member Reported by domenic@chromium.org, Oct 24 2016 
In https://bugs.chromium.org/p/chromium/issues/detail?id=639477 the use counters have come back for the strange Unicode case-insensitive matching used by these constructs: radio button groups, <img usemap>, and <object usemap>. The results were that the Unicode code path was never triggered and the ASCII case-insensitive code path was triggered on <0.0001% of pages.

As such, we changed the spec in https://github.com/whatwg/html/commit/6acdb2122298d2bb7bb839c0a61b4e1f9b0f9bc9 to use simple case-sensitive matching for these strings (which should be treated as identifiers anyway). Web platform tests are available at:

- http://w3c-test.org/html/semantics/forms/the-input-element/radio-groupname-case.html
- http://w3c-test.org/html/semantics/embedded-content/the-img-element/usemap-casing.html
- http://w3c-test.org/html/semantics/embedded-content/the-object-element/usemap-casing.html

Comment 1 by domenic@chromium.org, Oct 24 2016

Description: Show this description

Comment 2 by tkent@chromium.org, Oct 26 2016

Components: -Blink>HTML>Object -Blink>HTML>Map
Labels: Hotlist-GoodFirstBug Needs-BlinkIntent
Status: Available (was: Untriaged)
Summary: Remove (Unicode) case-insensitive matching for radio button groups (was: Remove (Unicode) case-insensitive matching for radio button groups and usemap attributes)
Let me separate this to
 - type=radio
 - usemap

Comment 3 by tkent@chromium.org, Oct 26 2016 

 Issue 659464  is for usemap.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/853295e62c2b9e035962c4f9cf871037d55c41b4

commit 853295e62c2b9e035962c4f9cf871037d55c41b4
Author: tkent <tkent@chromium.org>
Date: Thu Nov 17 08:52:48 2016

INPUT element: Deprecate case-insensitive matching for radio button group names.

This CL doesn't use Deprecation::countDeprecation() because we'd like to show a
deprecation warning message once per a pair of names. This CL introduces
FrameConsole::addSingletonMesssage().

Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/_p93QV64cFA/ZRAphH_9AgAJ

BUG= 658749 

Review-Url: https://codereview.chromium.org/2502763004
Cr-Commit-Position: refs/heads/master@{#432818}

[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt
[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio-expected.txt
[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio-groupname-case-expected.txt
[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/Source/core/frame/FrameConsole.h
[modify] https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp

Comment 5 by tkent@chromium.org, Dec 20 2016

Owner: tkent@chromium.org
Status: Started (was: Available)

Comment 6 by tkent@chromium.org, Dec 20 2016

Labels: -Needs-BlinkIntent
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70db105cf04846a32da6a388d6ade05c12f2ea17

commit 70db105cf04846a32da6a388d6ade05c12f2ea17
Author: tkent <tkent@chromium.org>
Date: Wed Dec 21 02:22:14 2016

INPUT element: Remove case-insensitive matching for radio button group names.

This CL removes fast/forms/radio/radio-group-name-case.html. The feature is well
tested by web-platform-tests.

Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/_p93QV64cFA/ZRAphH_9AgAJ

BUG= 658749 

Review-Url: https://codereview.chromium.org/2594593002
Cr-Commit-Position: refs/heads/master@{#439983}

[delete] https://crrev.com/f21d6e5f8417163e52730a30b9e85fb6cfd6f251/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-name-case-expected.txt
[delete] https://crrev.com/f21d6e5f8417163e52730a30b9e85fb6cfd6f251/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-name-case.html
[modify] https://crrev.com/70db105cf04846a32da6a388d6ade05c12f2ea17/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio-expected.txt
[delete] https://crrev.com/f21d6e5f8417163e52730a30b9e85fb6cfd6f251/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio-groupname-case-expected.txt
[modify] https://crrev.com/70db105cf04846a32da6a388d6ade05c12f2ea17/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/70db105cf04846a32da6a388d6ade05c12f2ea17/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/70db105cf04846a32da6a388d6ade05c12f2ea17/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/70db105cf04846a32da6a388d6ade05c12f2ea17/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.h

Comment 8 by tkent@chromium.org, Dec 21 2016

Labels: M-57
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/787c2c27b928f485bdbbd469bc132f6d3789294f

commit 787c2c27b928f485bdbbd469bc132f6d3789294f
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed Nov 01 15:33:29 2017

Remove blink::FrameConsole::AddSingletonMessage method (no callers).

There are no callers of blink::FrameConsole::AddSingletonMessage, so
let's just remove this old method and the related |singleton_messages_|
field.  The method was introduced in r432818 and the last caller
was removed in r439983.

Bug:  658749 
Change-Id: Icaca101d6ef65cdfbf2557c4569d6ba1179c236c
Reviewed-on: https://chromium-review.googlesource.com/747271
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513136}
[modify] https://crrev.com/787c2c27b928f485bdbbd469bc132f6d3789294f/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/787c2c27b928f485bdbbd469bc132f6d3789294f/third_party/WebKit/Source/core/frame/FrameConsole.h
►

Sign in to add a comment