File picker: <esc> should close preview but not dialog |
||||||
Issue descriptionChrome Version: 55.0.2883.17 OS Version: 8872.15.0 What steps will reproduce the problem? (1) Click an "Attach a file" button on crbug.com (2) Select a screenshot (3) Press <spacebar> to preview screenshot (4) Press <esc> to go back to list What is the expected output? Preview closes but file selection dialog does not What do you see instead? File selection dialog also closes without letting you select a file Please use labels and text to provide additional information.
,
Nov 7 2016
,
Nov 7 2016
,
Nov 7 2016
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ef31bd8ba19d23fa815ae76dcedaa9b77751d72 commit 4ef31bd8ba19d23fa815ae76dcedaa9b77751d72 Author: oka <oka@chromium.org> Date: Wed Nov 09 09:15:15 2016 Prevent Escape key from closing open file dialog when Quick View is opening. TEST=manually. BUG= 658745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2480123002 Cr-Commit-Position: refs/heads/master@{#430900} [modify] https://crrev.com/4ef31bd8ba19d23fa815ae76dcedaa9b77751d72/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
,
Nov 11 2016
,
Nov 14 2016
Verified on ChromeOS 8989.0.0, 56.0.2919.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weifangsun@chromium.org
, Oct 26 2016