Update download notification with states |
||||||||||
Issue descriptionWe have LGTM from UI Review on our proposal to update download notifications. Proposal here: https://docs.google.com/presentation/d/1dFz09wgzykFM-_-XZh9PKDbTLAz_HDKVgPBMGCEASZA/edit#slide=id.g1781ef71a3_0_200 Please update the download notification to include these states (consistent with progress shown in downloads home): [scheduled] - Download pending... [In progress] - Downloading... [Interrupted connection] - Download waiting... [complete] - Download complete
,
Nov 4 2016
,
Nov 4 2016
,
Nov 9 2016
,
Nov 9 2016
For regular download,we have the remaining time and percentage text on the notification. If we choose to use "Downloading...." text, are we going to drop the percentage text? And I did not see the remaining time/percentage text in the UI mockups, seems the mockups only matches that of the offline pages.
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d commit 9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d Author: qinmin <qinmin@chromium.org> Date: Fri Nov 11 02:07:15 2016 Use new download notification strings This CL adds new download notification strings: [scheduled] - Download pending... [In progress] - Downloading... [Interrupted connection] - Download waiting... [complete] - Download complete BUG=658744 Review-Url: https://codereview.chromium.org/2489143002 Cr-Commit-Position: refs/heads/master@{#431462} [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/components/offline_pages/downloads/download_ui_item.cc [modify] https://crrev.com/9f6bbeb42b766bc9b4385e409a6adb88a85e6c8d/components/offline_pages/downloads/download_ui_item.h
,
Nov 18 2016
Fyi, I am seeing odd notification UI currently (at head). Perhaps still in progress but wanted to mention it. 1. For a pending web page download I see "Downloading..." string with indeterminate progress bar. 2. For an active web page download I see "Downloading..." string with "0sec" remaining but no progress bar. 3. If I have one of each and swipe away Chrome, then I see "Download pending..." string for both.
,
Nov 20 2016
,
Nov 22 2016
John, looks like this bug is pending on you for clarity per comment #5 from Min. My understanding for offline pages where we do not provide a percentage progress, we should have: 1. For scheduled/pending: "Pending..." string with no animation 2. In progress/offlining: "Downloading..." string with indeterminate animation (for web page) [and determinate progress bar for downloads?] 3. Swipe away Chrome" "Pending..." string with no animation Does that sound right? In comment #7 above I note what I actually experienced. I think the "0 secs" is not longer displayed more recently. Dmitry opened bug on the 3rd case here: https://bugs.chromium.org/p/chromium/issues/detail?id=667011
,
Nov 22 2016
Comment #9 sounds right to me. BTW, a CL fixing #1 and #3 is getting landed: https://codereview.chromium.org/2514783003/
,
Nov 23 2016
I think there still are some issues getting to the UX for web pages. #3: [chrome killed] I checked again with Dmitry's patch and it does remove the indeterminate progress for the case when you swipe away chrome. However, the icon is still animating which does not fit the UX deck slide #5 text description: "While download is pending, we won’t animate the icon in the status bar." #1: [scheduled] Still showing as "Downloading..." for me rather then "Download pending..." and still showing indetereminate bar. #2: [downloading] Still does not show indeterminate progress bar.
,
Nov 23 2016
,
Dec 1 2016
I think 1, 2, and most of 3 in comment 11 are now fixed via blocking issue 668231 What is still not addressed is that the icon is still animating for the pending case.
,
Dec 1 2016
,
Dec 6 2016
,
Feb 6 2018
,
Jul 25
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dfalcant...@chromium.org
, Oct 24 2016Owner: qin...@chromium.org
Status: Assigned (was: Untriaged)