Link downloads notification to downloads home (new progress feature) |
|||
Issue descriptionWe have LGTM from UI Review to show download progress in the downloads home, which means that we can link from the downloads notification to downloads home. Mocks and additional information found here: https://docs.google.com/presentation/d/1dFz09wgzykFM-_-XZh9PKDbTLAz_HDKVgPBMGCEASZA/edit#slide=id.g1781ef71a3_0_200 Please request additional specs if needed.
,
Oct 24 2016
,
Dec 12 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6 commit fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6 Author: dfalcantara <dfalcantara@chromium.org> Date: Wed Dec 14 19:52:33 2016 [Downloads] Various fixes * Clicking on an in-progress or paused download now sends the user to Download Home instead of doing nothing. This uses the existing Intent broadcasting mechanism, using a lack of download IDs in the Intent as a signal that Download Home should be opened instead. * Unifies the DownloadBroadCastReceiver and DownloadManagerService pathways for opening a download. This also fixes an assert that called a method on the UI thread instead of in the background. * Failing to open a download now sends the user to Download Home instead of silently failing. * Cleans up some code in DownloadNotificationService. * Prevents showing unresumable files in Download Home. This happens if the user tries to download a file that is "interrupted" when a file doesn't exist (e.g.). * Disallow long pressing on an incomplete file in Download Home. BUG=658246, 658742 Review-Url: https://codereview.chromium.org/2571623002 Cr-Commit-Position: refs/heads/master@{#438600} [modify] https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java [modify] https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
,
Dec 14 2016
Handled this at the same time I was fixing a crash. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dfalcant...@chromium.org
, Oct 24 2016Owner: dfalcant...@chromium.org
Status: Assigned (was: Untriaged)