New issue
Advanced search Search tips

Issue 658732 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Oct 2016
Cc:
battre@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

Credential Manager API should be suppressed for prerendered pages

Project Member Reported by vasi...@chromium.org, Oct 24 2016 
Version: 55.0.2883.21
OS: all
What steps will reproduce the problem?
(1) Open chrome://password-manager-internals/
(2) Google for "pinterest"
(3) Wait for a few seconds and observe the log in chrome://password-manager-internals/ and the Chrome task manager.

There is a prerenderer tab for pinterest. In that tab the site tried to get a credential from the browser. If you have a valid autosignin credential then we'd return it back to the site.

In the similar cases the prerenderer destroys the tab if
- the page uses JS alert(), or
- the page uses an audio stream, or
- the site requires HTTP auth in LoginHandler::ShowLoginPrompt. This is a  twin scenario.

CM API should be handled similarly.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845

commit 7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845
Author: vasilii <vasilii@chromium.org>
Date: Thu Oct 27 12:54:12 2016

Stop prerendering of a site if it uses the Credential Manager API.

BUG= 658732 

Review-Url: https://codereview.chromium.org/2447143002
Cr-Commit-Position: refs/heads/master@{#428007}

[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/chrome/browser/prerender/prerender_final_status.cc
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/chrome/browser/prerender/prerender_final_status.h
[add] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/chrome/test/data/password/autosignin.html
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/components/password_manager/content/browser/credential_manager_impl.cc
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/components/password_manager/content/browser/credential_manager_impl_unittest.cc
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/7926e90cb2f6b25fd19ed9a4e37bbbd0e37b3845/tools/metrics/histograms/histograms.xml

Comment 3 by vasi...@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)

Comment 5 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment