New issue
Advanced search Search tips

Issue 658713 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 639295



Sign in to add a comment

Gate signature checks in cros libpolicy on install attributes.

Project Member Reported by tnagel@chromium.org, Oct 24 2016

Issue description

Waive device policy signature checks for install attributes device mode "enterprise_ad".
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3eb175c9bd162e0af2edef04137e86073b383fd7

commit 3eb175c9bd162e0af2edef04137e86073b383fd7
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Tue Oct 25 13:22:52 2016

common-mk: Add install attributes proto rule.

external_dependencies.gyp:policy-protos blows up any .so that's linking
it by 400k.  Adding external_dependencies.gyp:install_attributes-proto
which is only a few kB in size for use by libinstallattributes.

BUG= chromium:658713 
TEST=manally tested that compilation succeeds

Change-Id: I892804c34580d34c53ce6ed7e50c4753d8035825
Reviewed-on: https://chromium-review.googlesource.com/402929
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3eb175c9bd162e0af2edef04137e86073b383fd7/common-mk/external_dependencies.gyp

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/16e99ebcbdaa86de6b073c40f0ed670fe2cb5777

commit 16e99ebcbdaa86de6b073c40f0ed670fe2cb5777
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Mon Oct 24 13:29:04 2016

Add libinstallattributes to libbrillo ebuild.

BUG= chromium:658713 
TEST=none
CQ-DEPEND=CL:402148

Change-Id: I7a409af2dd302e9969d18158df274a49d6423f0a
Reviewed-on: https://chromium-review.googlesource.com/400820
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/16e99ebcbdaa86de6b073c40f0ed670fe2cb5777/chromeos-base/libbrillo/libbrillo-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/ce533da748d089c6f1cbd8a0b3b22713a5e229a6

commit ce533da748d089c6f1cbd8a0b3b22713a5e229a6
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Mon Oct 24 12:53:14 2016

libbrillo: Add new install attributes library.

Based on that new library, waive signature verification in libpolicy
when verified install attributes device mode is enterprise_ad.

BUG= chromium:658713 
TEST=unittests
CQ-DEPEND=CL:400820

Change-Id: I650913c6faf48f215cc28b147175d37f0651cb1a
Reviewed-on: https://chromium-review.googlesource.com/402148
Commit-Ready: Roman Sorokin <rsorokin@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/policy/libpolicy.cc
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/tests/libinstallattributes_unittest.cc
[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/policy/libpolicy.h
[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/libbrillo.gyp
[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/libbrillo.gypi
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/tests/managed.pb
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/mock_install_attributes_reader.h
[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/policy/device_policy_impl.h
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/libinstallattributes.gypi
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/mock_install_attributes_reader.cc
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/libinstallattributes.cc
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/tests/consumer.pb
[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/policy/tests/libpolicy_unittest.cc
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/tests/corrupt.pb
[add] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/install_attributes/libinstallattributes.h
[modify] https://crrev.com/ce533da748d089c6f1cbd8a0b3b22713a5e229a6/policy/device_policy_impl.cc

Comment 4 by tnagel@chromium.org, Oct 29 2016

Blocking: 639295
Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cffe5498f344f2c8ffc8ac724cb0df33d97e82ec

commit cffe5498f344f2c8ffc8ac724cb0df33d97e82ec
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Wed Oct 26 12:59:23 2016

common-mk: Drop install attributes from policy-protos.

Dropping install attributes from external_dependencies.gyp:policy-protos
now that we have external_dependencies.gyp:install_attributes-proto.
Also remove useless -fvisibility=hidden cflags.

BUG= chromium:658713 
TEST=manually tested that compilation succeeds

Change-Id: I91a161a244b7c7405cb740c709bf8425fb9a5885
Reviewed-on: https://chromium-review.googlesource.com/403888
Commit-Ready: Thiemo Nagel <tnagel@chromium.org>
Tested-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/cffe5498f344f2c8ffc8ac724cb0df33d97e82ec/common-mk/external_dependencies.gyp
[modify] https://crrev.com/cffe5498f344f2c8ffc8ac724cb0df33d97e82ec/login_manager/login_manager.gyp

Labels: Enterprise-Triaged

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment