Issue metadata
Sign in to add a comment
|
Rietveld insists on codereview.chromium.org links for codereview.webrtc.org |
||||||||||||||||||||||
Issue descriptionDue to a recent upgrade of Rietveld, a change [1] was deployed that seems to rewrite all custom hosts in links --> codereview.chromium.org. Because of that all links to reviews at codereview.webrtc.org are translated to codereview.chromium.org. This is not a big problem but it's: * confusing to reviewers * easy to mistake the review for a Chromium review * easy to accidentally use the wrong credentials if you also have a chromium.org account. Can we fix this for the codereview.webrtc.org alias? We're using the same instance but with another host. [1]: https://chromium-review.googlesource.com/#/c/400661/
,
Oct 24 2016
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/9387bc4063ccb79123e643c46a315b0df9edaa04 commit 9387bc4063ccb79123e643c46a315b0df9edaa04 Author: Aaron Gable <agable@chromium.org> Date: Mon Oct 24 20:48:58 2016 Rietveld: Always take into account project when rewriting urls BUG= 658699 Change-Id: I963b535545c775ba9cb9aceb1488f9236aba8e58 Reviewed-on: https://chromium-review.googlesource.com/402252 Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9387bc4063ccb79123e643c46a315b0df9edaa04/appengine/chromium_rietveld/codereview/common.py [modify] https://crrev.com/9387bc4063ccb79123e643c46a315b0df9edaa04/appengine/chromium_rietveld/codereview/views.py
,
Oct 24 2016
Yep, when uploading to the new server, the "Issue created" url is now codereview.webrtc.org. And the email says the same thing. Deploying the new version of the app.
,
Oct 24 2016
New version has been deployed. Henrik, please let me know if you're still seeing the wrong URLs.
,
Oct 25 2016
Thanks for addressing this so quickly! I can confirm the right URL is presented now for us.
,
Nov 15 2016
[bulk-edit : please ignore if not applicable] Could you please set the correct milestone for this issue? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aga...@chromium.org
, Oct 24 2016