New issue
Advanced search Search tips

Issue 658699 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Rietveld insists on codereview.chromium.org links for codereview.webrtc.org

Project Member Reported by kjellander@chromium.org, Oct 24 2016

Issue description

Due to a recent upgrade of Rietveld, a change [1] was deployed that seems to rewrite all custom hosts in links --> codereview.chromium.org.

Because of that all links to reviews at codereview.webrtc.org are translated to codereview.chromium.org. 
This is not a big problem but it's:
* confusing to reviewers
* easy to mistake the review for a Chromium review 
* easy to accidentally use the wrong credentials if you also have a chromium.org account. 

Can we fix this for the codereview.webrtc.org alias? We're using the same instance but with another host.

[1]: https://chromium-review.googlesource.com/#/c/400661/
 

Comment 1 by aga...@chromium.org, Oct 24 2016

Rietveld has historically had two ways of determining what domain name it should use when showing a URL to the user (e.g. in the UI, in emails, or returned to 'git cl upload' to print in the terminal):
* Just echo whatever hostname the user used. This codepath has been used in emails and in output returned to git-cl-upload.
* Use a dict to look up what domain name is preferred for the given project. This codepath has been used in a couple specific emails.

The new deployment caused the second codepath to be used in all cases. The second codepath has support for noticing that the "project" is webrtc, and in such cases, returning "codereview.webrtc.org" instead. However, apparently Rietveld just doesn't bother passing the "project" parameter around all the time, so it is falling back to to the default "codereview.chromium.org" in the places where it used to simply echo back whatever domain the user used.

I'll try to add plumbing to make sure that it always knows to pass the 'project' parameter through.

Comment 2 by aga...@chromium.org, Oct 24 2016

Status: Started (was: Assigned)
This should help: https://chromium-review.googlesource.com/402252
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/9387bc4063ccb79123e643c46a315b0df9edaa04

commit 9387bc4063ccb79123e643c46a315b0df9edaa04
Author: Aaron Gable <agable@chromium.org>
Date: Mon Oct 24 20:48:58 2016

Rietveld: Always take into account project when rewriting urls

BUG= 658699 

Change-Id: I963b535545c775ba9cb9aceb1488f9236aba8e58
Reviewed-on: https://chromium-review.googlesource.com/402252
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/9387bc4063ccb79123e643c46a315b0df9edaa04/appengine/chromium_rietveld/codereview/common.py
[modify] https://crrev.com/9387bc4063ccb79123e643c46a315b0df9edaa04/appengine/chromium_rietveld/codereview/views.py

Comment 4 by aga...@chromium.org, Oct 24 2016

Yep, when uploading to the new server, the "Issue created" url is now codereview.webrtc.org. And the email says the same thing.

Deploying the new version of the app.
Screenshot from 2016-10-24 15:22:26.png
15.0 KB View Download
Screenshot from 2016-10-24 15:23:12.png
6.6 KB View Download

Comment 5 by aga...@chromium.org, Oct 24 2016

Status: Fixed (was: Started)
New version has been deployed. Henrik, please let me know if you're still seeing the wrong URLs.
Thanks for addressing this so quickly! I can confirm the right URL is presented now for us.
[bulk-edit : please ignore if not applicable]

Could you please set the correct milestone for this issue?

Sign in to add a comment