New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658688 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Blank ‘Manage exceptions’ tab is seen after clicking on Help/Learn more button in any Subpage of Content Settings.

Reported by yfulgaon...@etouch.net, Oct 24 2016

Issue description

Chrome Version : 56.0.2899.0 (Official Build) bb7071018e1fd8bf223b8ffff660883b7d17278d-refs/heads/master@{#426989} 64-bit
OS : Mac(10.10.5, 10.11.4, 10.11.5)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/siteSettings and click on ‘Cookies’.
2. In ‘Cookies’ subpage, click on ‘Help/Learn more’ button seen in the upper right corner and observe the ‘Manage exceptions’ tab. 

Actual : Blank ‘Manage exceptions’ tab is seen after clicking on Help/Learn more button in any Subpage of Content Settings. 
Expected : ‘Manage exceptions’ tab should be seen properly after clicking Help/Learn more button.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info.
Good build : 56.0.2897.0
Bad build : 56.0.2899.0

Note : 
1. The previous ’Learn more’ functionality is now converted into new ‘help’ button, seen in the upper right of the subpage.
2. This is Mac OS specific issue and the same is working fine on Windows and Linux OS.
 
Actual_md-siteSettings.mov
5.2 MB Download
Expected_md-siteSettings.mov
7.0 MB Download
Labels: Proj-MaterialDesign-WebUI Needs-Bisect
Status: Untriaged (was: Unconfirmed)

Comment 2 by hdodda@chromium.org, Oct 24 2016

Cc: hdodda@chromium.org
Labels: -hasbisect -Needs-Bisect hasbisect-per-revision
Owner: lfg@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build:56.0.2897.0(Revision:426673).
Bad build: 56.0.2899.0(Revision:426989).

You are probably looking for a change made after 426912 (known good), but no later than 426913 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/58290e535d3de7a235e13b6f023b1c8bf06a223a..7c3d7bbd510eda2bcfb971f6d166da26bcfe4222

From the CL above, assigning the issue to the concern owner 

@lfg- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://chromiumcodereview.appspot.com/2415973002

Thanks !
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b746a0ef62cc611f7b79b4cc6a2d7cebb982f3e

commit 4b746a0ef62cc611f7b79b4cc6a2d7cebb982f3e
Author: lfg <lfg@chromium.org>
Date: Mon Oct 24 17:24:58 2016

Revert of Do not hide the old RenderWidgetHostView when commiting a navigation. (patchset #2 id:20001 of https://codereview.chromium.org/2415973002/ )

Reason for revert:
Caused a regression on Mac.

BUG= 658688 

Original issue's description:
> Do not hide the old RenderWidgetHostView when commiting a navigation.
>
> This fixes an issue where the old RenderView is reused by a new remote
> subframe. We shouldn't be leaking resources, because now we are already
> hiding the unused RenderView in the renderer, when the local main frame
> gets detached and the WebViewFrameWidget is closed.
>
> BUG= 638375 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/7c3d7bbd510eda2bcfb971f6d166da26bcfe4222
> Cr-Commit-Position: refs/heads/master@{#426913}

TBR=creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 638375 

Review-Url: https://codereview.chromium.org/2448503002
Cr-Commit-Position: refs/heads/master@{#427091}

[modify] https://crrev.com/4b746a0ef62cc611f7b79b4cc6a2d7cebb982f3e/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/4b746a0ef62cc611f7b79b4cc6a2d7cebb982f3e/content/browser/site_per_process_browsertest.cc

Labels: TE-Verified-56.0.2900.0 TE-Verified-M56
Rechecked this on chrome version 56.0.2900.0 on MAC 10.11.6, fix is working as intended. No blank page is displayed when clicked on "Help" / "?" icon for the options available in "chrome://md-settings/siteSettings" Page.

Adding TE-Verified labels.
Labels: TE-Verified-56.0.2902.0
Just to update, rechecked this on chrome version 56.0.2902.0 on MAC 10.11.6, fix is working as intended. No blank page is displayed when clicked on "Help" / "?" icon for the options available in "chrome://md-settings/siteSettings" Page.

Comment 6 by lfg@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)

Comment 7 by lfg@chromium.org, Oct 27 2016

Cc: ligim...@chromium.org vogelheim@chromium.org hablich@chromium.org bustamante@chromium.org gov...@chromium.org jgruber@chromium.org lfg@chromium.org
 Issue 658643  has been merged into this issue.

Sign in to add a comment