New issue
Advanced search Search tips

Issue 658683 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 517087



Sign in to add a comment

Migrate password manager setting.

Project Member Reported by melandory@chromium.org, Oct 24 2016

Issue description

After the reconciliation experiment is over, password Manager should stop using password_manager::prefs::kPasswordManagerSavingEnabled
and start using
password_manager::prefs::kCredentialEnableService

Ideally, should be implemented by M56.
 

Comment 1 by vabr@chromium.org, Oct 24 2016

Labels: Hotlist-TechnicalDebt M-56 Hotlist-GoodFirstBug
Just to clarify -- is the experiment over yet? Or will you update this bug when it will be?

Thanks for filing this!

Vaclav
Experiment (if it will not be prolonged) has M56 as end milestone set by Finch config
Blocking: 517087
https://codereview.chromium.org/1273053002/ there is this dummy CL, which does some part of the work.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2af32fde9d68961f9fd41c824441627acd6be8

commit 3f2af32fde9d68961f9fd41c824441627acd6be8
Author: melandory <melandory@chromium.org>
Date: Tue Feb 14 11:57:52 2017

Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference will be not exposed anymore. The two preferences have same values, because they were reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087,  658683 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1273053002
Cr-Commit-Position: refs/heads/master@{#450326}

[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/3f2af32fde9d68961f9fd41c824441627acd6be8/components/password_manager/core/browser/password_generation_manager_unittest.cc

Labels: -M-56 M-57 Merge-Request-57
Status: Fixed (was: Available)
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 15 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 Deleted

If possible, could you please merge your CL into M57 branch 2987 before 5 PM PT today, Wednesday (02/15/17). Thank you.
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ca30d63ded3525cdab87cb205161ba3751b75ab

commit 7ca30d63ded3525cdab87cb205161ba3751b75ab
Author: Tatiana Gornak <melandory@chromium.org>
Date: Thu Feb 16 09:27:42 2017

Use Smart Lock preference instead of Chrome Password manager preference.

After this CL the ability to change  Chrome Password manager preference will be not exposed anymore. The two preferences have same values, because they were reconciled previously.

Smart Lock preference: credentials_enable_service
Chrome Password Manager preference: profile.password_manager_enabled

BUG=517087,  658683 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1273053002
Cr-Commit-Position: refs/heads/master@{#450326}
(cherry picked from commit 3f2af32fde9d68961f9fd41c824441627acd6be8)

Review-Url: https://codereview.chromium.org/2693373004 .
Cr-Commit-Position: refs/branch-heads/2987@{#540}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/resources/options/browser_options.html
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/7ca30d63ded3525cdab87cb205161ba3751b75ab/components/password_manager/core/browser/password_generation_manager_unittest.cc

Cc: -vabr@chromium.org

Sign in to add a comment