New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658675 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
█ talo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

bluetooth: French translations should be consistent on Desktop and Mobile

Project Member Reported by fbeaufort@chromium.org, Oct 24 2016 
On Android[1],

      <!-- Bluetooth Picker UI strings -->
      <message name="IDS_BLUETOOTH_DIALOG_TITLE" desc="The header message shown on top of the dialog that lets the user pick a Bluetooth device for the site to pair with. Shown above a list of Bluetooth devices discovered. ">
        <ph name="SITE">%1$s<ex>https://www.google.com</ex></ph> wants to pair with:</message>
     
translates in French in

<translation id="7074853159844403180">Le site <ph name="SITE" /> souhaite être associé à l'appareil suivant :</translation>


While on Desktop[2], same string below,

      <!-- Device Chooser Prompt -->
      <message name="IDS_BLUETOOTH_DEVICE_CHOOSER_PROMPT_ORIGIN" desc="The label that is used to introduce Bluetooth chooser details to the user in a popup when it is from a website.">
        <ph name="Origin">$1<ex>www.google.com</ex></ph> wants to pair with:
      </message>
      <message name="IDS_BLUETOOTH_DEVICE_CHOOSER_PROMPT_EXTENSION_NAME" desc="The label that is used to introduce Bluetooth chooser details to the user in a popup when it is from a Chrome extension.">
        "<ph name="CHROME_EXTENSION_NAME">$1<ex>Chrome extension name</ex></ph>" wants to pair with:
      </message>

translates in French

<translation id="4361765875689149937"><ph name="ORIGIN" /> tente de s'associer à :</translation>
<translation id="7469206789121791392">"<ph name="CHROME_EXTENSION_NAME" />" tente de s'associer à :</translation>


Can we please make sure all translations are consistent across Desktop and Mobile?

[1] https://chromium.googlesource.com/chromium/src/+/9add242a47f0986e96f4c63cae7e68552c6a2878/chrome/android/java/strings/android_chrome_strings.grd#1197
[2] https://chromium.googlesource.com/chromium/src/+/9add242a47f0986e96f4c63cae7e68552c6a2878/chrome/app/generated_resources.grd#15088

Comment 1 by fbeaufort@chromium.org, Oct 24 2016 

As you can see in screenshots below, there are more:

Android: "Votre appareil ne s'affiche pas ?"
Desktop: "Votre appareil n'est pas affiche ?"

both for "Not seeing your device?"

Android: "Obtenez l'aide" (by the way, this is not french...)
Desktop: "Obtenir de l'aide" (proper french)

both for "Get help" link
android.png
174 KB View Download
chromeos.png
135 KB View Download

Comment 2 by juncai@chromium.org, Oct 24 2016 

I think it is related to the desc that is given to the string, since it is the only context that the translator knows when translating the string. I am doing some experiments to verify that.

Comment 3 by fbeaufort@chromium.org, Oct 25 2016 

(just pinged chrome-translate@)

Comment 4 by zkoch@chromium.org, Oct 25 2016

Cc: talo@chromium.org
Hm, so chrome-translate more refers to the Google Translate powered translations in Chrome, not so much our own translations. I'm actually not sure who the best point of reference for that is. I know +Tal has looked into translations for EM, so Tal, can you CC the right person to speak to translations in Chrome if you know?

Comment 5 by groby@chromium.org, Oct 25 2016 

So... that's a non-trivial issue. First - all translations are handled via the translate console. 

That translate console _tries_ to consolidate identical strings, which sometimes leads to a different kind of hilarious bug. (See bug #614861)

In this particular case, I would assume the two strings are not collapsed because one is:
    <ph name="SITE">%1$s<ex>https://www.google.com</ex></ph> wants to pair with:
and the other is:
    "<ph name="CHROME_EXTENSION_NAME">$1<ex>Chrome extension name</ex></ph>" wants to pair with:

If we assume console is smart enough to ignore the markup, the strings still differ - the URL is wrapped in quotes for one, and is without quotes for the other.

I'd *assume* getting the quotes consistent will result in a consistent translation. Tal might know more of the magic details.

Comment 6 by fbeaufort@chromium.org, Oct 26 2016 

Here are android and desktop messages with added spaces to show how much different they are:

Android: <ph name="SITE">   %1$s <ex>https://www.google.com</ex></ph> wants to pair with:
Desktop: <ph name="Origin"> $1   <ex>www.google.com</ex></ph>         wants to pair with:

As you can see, there are no quotes involved in these messages.
Hopefully, Tal will be able to help us there.

Comment 7 by scheib@chromium.org, Nov 5 2016

Blocking: -436283
Are the differing translations incorrect, or is it only that they are inconsistent? Presuming the latter, this should not block launch.

Comment 8 by juncai@chromium.org, Mar 15 2017 

Any update on this issue?

Comment 9 by fbeaufort@chromium.org, Mar 16 2017

Status: Fixed (was: Available)
It has been fixed by cbrun@ 12/6/16.
See  https://screenshot.googleplex.com/9AMGVDUCwOL and https://screenshot.googleplex.com/ah1gMXRz5GA
►

Sign in to add a comment