Unwanted blank tab gets opened after middle click on pdf link.
Reported by
yfulgaon...@etouch.net,
Oct 24 2016
|
||||||||||
Issue descriptionChrome Version : 56.0.2899.0 (Official Build) bb7071018e1fd8bf223b8ffff660883b7d17278d-refs/heads/master@{#426989} 32/64-bit OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://settings/content and scroll down to the ‘PDF Documents’ section. 2. Check the ‘Open PDF files in default..’ checkbox, open NTP, type ‘Test PDF’ in omnibox and hit ENTER key. (google search results are seen) 3. Now middle click on “This is a test PDF file” link and observe. Actual : Unwanted blank tab gets opened after middle click pdf link. Expected : Instead, on middle click, PDF file should get downloaded but no blank tab should appear. This is a Non-Regression issue seen from M-55 build 55.0.2882.0 as ‘Open PDF files in default PDF viewer’ option was introduced in ‘content settings’ from this build.
,
Oct 24 2016
Able to reproduce the issue using chrome version 56.0.2899.0
,
Oct 24 2016
I think this corresponds to a new feature added by pastarmovj@
,
Oct 25 2016
Yes this could be related to my recent changes. I will take ownership of this issue.
,
Oct 27 2016
asanka, can you please give me a hint how do downloads usually trigger closing of tags that result in a download of the URL? It seems like what I did for the PDFs somehow doesn't trigger this logic.
,
Oct 27 2016
The logic is at https://cs.chromium.org/chromium/src/chrome/browser/download/download_ui_controller.cc?rcl=0&l=160 But it won't trigger in this case since the target of the outgoing links from Google Search is an HTML page with a script. The download happens via a second navigation initiated from this script. The tab auto-closing behavior only triggers if the only navigation on that tab was the download. Otherwise we'd close legitimate tabs with content. See also b/5821520 (sorry, internal link).
,
Oct 27 2016
Ah right I completely missed this part so I think we can close this as working-as-intended then? It is a mild annoyance I can admit but not much we can do in this regard I fear.
,
Oct 27 2016
Yeah. WAI unfortunately. :-/
,
Oct 27 2016
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yfulgaon...@etouch.net
, Oct 24 2016