VDA unittest: need a test to verify visible size returned in PictureReady |
|||
Issue descriptionTo catch bugs like b/32354993, we need a test to verify visible size returned in PictureReady. The wrong visible size doesn't seem to affect chromium. But Android CTS ImageReaderDecoderTest#testOtherVP9Image will fail.
,
Oct 26 2016
How about just verify the visible size in every test?
,
Oct 26 2016
Having a stand-alone test case is more clear. For example, we don't want to catch visible size bug in Thumbnail test. Can we add a new testcase like TestDecodeTimeMedian? https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest.h?l=446
,
Nov 14 2016
Owen. Have you started this? If not, I can assign this to someone else for load balancing.
,
Nov 15 2016
Yes, I have started this.
,
Nov 17 2016
CL upload for review: https://codereview.chromium.org/2506363002
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9806cd6a5d72359007cc569abc843f48a53d94e3 commit 9806cd6a5d72359007cc569abc843f48a53d94e3 Author: owenlin <owenlin@chromium.org> Date: Mon Nov 21 04:29:20 2016 vda_unittest: Verify the visible rectangle of returned picture. Verify the visible rectangle of the picture returned from PictureReady(). It could be empty if the information is not available from the VDA. BUG= 658654 Test=Run and pass the vda_unittest CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2518463002 Cr-Commit-Position: refs/heads/master@{#433473} [modify] https://crrev.com/9806cd6a5d72359007cc569abc843f48a53d94e3/media/gpu/video_decode_accelerator_unittest.cc
,
Nov 21 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wuchengli@chromium.org
, Oct 26 2016Status: Assigned (was: Available)