New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658648 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Traces of blue highlight is seen after zooming the page in chrome://downloads

Reported by vku...@etouch.net, Oct 24 2016

Issue description

Chrome Version: 56.0.2899.0 (Official Build)Revision bb7071018e1fd8bf223b8ffff660883b7d17278d-refs/heads/master@{#426989}(32/64-bit)
OS:Windows (7,8,10)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://cb.vu/unixtoolbox.pdf 
(2)Click on 'download' button,press ctrl+J to open download.
(3)Zoom in the page to 250 % ,press tab key such that focus reaches close button,observe.

Actual: Traces of blue highlight is seen after zooming the page.

Expected: Traces of blue highlight should not be seen after zooming the page.

This is a regression issue broken in 'M56' and will soon update other info.


 

Comment 1 by vku...@etouch.net, Oct 24 2016

Labels: OS-Linux
Manual regression range:
Good Build: 56.0.2886.0
Bad Build: 56.0.2888.0

Note: Issue not seen on Mac OS.
Download.png
29.6 KB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Cc: brajkumar@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
You are probably looking for a change made after 424608 (known good), but no later than 424609 (first known bad).

CHANGELOG URL:
-----------------
https://chromium.googlesource.com/chromium/src/+log/751e1f52e94d3d611e27571de632b6a8faa7fc34..42c6683729d8e049fdcc89e552bdcff5fb337227

From the CL above, assigning the issue to the concern owner 

@eugenebut - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Cc: eugene...@chromium.org
Owner: tapted@chromium.org
This is very likely caused by my CL. Trent, could you please find another owner for this issue (hopefully I did not break too many things). Thanks!
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression

Comment 6 by tapted@chromium.org, Oct 25 2016

Cc: cbiesin...@chromium.org tapted@chromium.org
Labels: Needs-Bisect
Owner: bsep@chromium.org
-> bsep

eugene's CL in that link (https://codereview.chromium.org/2404783002 -> r424609) only affects Mac. But this affects other platforms. I think the bisect went awry - can we do it again?

This looks like a blink issue - my first guess from the coarse bisect in https://chromium.googlesource.com/chromium/src/+log/56.0.2886.0..56.0.2888.0?pretty=fuller&n=10000 is r424596 -> https://codereview.chromium.org/2386033002 "Scale focus outline thickness with zoom level."

There's also r424580 -> https://codereview.chromium.org/2411073002 "[css-flexbox] Remove unnecessary call to adjustAlignmentForChild".

Comment 7 by bsep@chromium.org, Oct 25 2016

Hmm, I can see how my patch would have caused this. Since I increased the focus ring size maybe it's bleeding outside the area that's damaged on a focus change, so it's not being redrawn?

Strangely enough for me it's ONLY happening at 300% zoom exactly, not any larger or smaller zoom level.

I'm willing to investigate but this is somewhat outside my area of knowledge. If anyone has any pointers that would be very helpful.

Comment 8 by bsep@chromium.org, Oct 25 2016

Components: -UI>Browser>Downloads Blink>Focus Blink>Compositing
I can see this on other webpages not just the downloads page, so I'm changing the components.

Comment 9 by vku...@etouch.net, Oct 27 2016

Above issue is still reproducible on latest canary version i.e 	56.0.2901.0 (Official Build) 

Please find attached screencast
Actual_Result.mp4
409 KB View Download
Issue is still reproducible on win10 latest canary version 56.0.2905.0

bsep@, Could you please look  into this or route to appropriate dev for further investigation.

Comment 12 by bsep@chromium.org, Nov 1 2016

I have a CL fixing it but having some trouble landing it, so hold on: https://codereview.chromium.org/2460683002
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b18b97a7da62e85fc08eddaefbc95b49c4d7b648

commit b18b97a7da62e85fc08eddaefbc95b49c4d7b648
Author: bsep <bsep@chromium.org>
Date: Tue Nov 01 23:33:17 2016

Fix focus ring damage sometimes being 1 pixel off.

crrev.com/2386033002 changed the focus ring stroke from being 1 pixel to
being scaled based on the zoom level, which changed the type to a float.
When calculating the outdent (and thus damage) the width value lost
precsion and so at certain fractional zoom levels would leave a 1 pixel
line behind. This patch ceils the width value instead, to make sure that
pixel is redrawn when necessary.

R=bokan@chromium.org
BUG= 658648 

Review-Url: https://codereview.chromium.org/2460683002
Cr-Commit-Position: refs/heads/master@{#429153}

[modify] https://crrev.com/b18b97a7da62e85fc08eddaefbc95b49c4d7b648/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/b18b97a7da62e85fc08eddaefbc95b49c4d7b648/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp
[modify] https://crrev.com/b18b97a7da62e85fc08eddaefbc95b49c4d7b648/third_party/WebKit/Source/core/style/StyleBackgroundData.h

Comment 14 by bsep@chromium.org, Nov 1 2016

Status: Fixed (was: Assigned)
Components: Blink>HTML>Focus
Components: -Blink>Focus

Sign in to add a comment