New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658645 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
nyerramilli@chromium.org
finnur@chromium.org
tbuck...@chromium.org
patricia...@chromium.org
█ tkonch...@chromium.org
bettes@chromium.org
█ dschuyler@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 712446



Sign in to add a comment

[Site settings details] Unnecessary 'Add exception' is seen site settings even after Incognito session is ended.

Reported by dmascare...@etouch.net, Oct 24 2016 
Chrome Version:56.0.2899.0 bb7071018e1fd8bf223b8ffff660883b7d17278d-refs/heads/master@{#426989}
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome and open Incognito window,minimize it.
2. Navigate to chrome://md-settings/siteSettings/cookies and click on 'Add exception' such that dialog box gets open with 'Current incognito session only' enabled.
3. Add some exception (for eg: 'abc'), click on checkbox of 'Current incognito session only' and then click on 'Add'
4. Click on that exception link such that subpage gets open and then click 'Back arrow' such that page again navigate to chrome://md-settings/siteSettings/cookies
5. Close the incognito window and then click on 'Forward' arrow of the browser window,observe.

Actual: Subpage of 'Added exception' of ended Incognito section is seen.
Expected: Subpage of 'Added exception' of ended Incognito section should not be seen.

This is regression issue, broken in 'M 55' and below is manual bisect info:

Good build:55.0.2850.0 
Bad build:55.0.2851.0
Actual_incog.mp4
1.4 MB View Download

Comment 1 by finnur@chromium.org, Oct 24 2016

Cc: rolfe@chromium.org
Labels: OS-Chrome
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
OK, it looks like there are three issues here:
1) We allow Site Details to show details for a site, even if we've deleted all the contents for that site. 
2) The Site Details page is stale (should have removed the Cookie entry).
3) The Site Details page should show "Current Incognito session only", or something, for the Cookie rule. I'm not sure this has been spec'ed out, though, and probably should be treated as a separate bug.

I'd say of these three the first is least important, as long as we fix the staleness. We could call navigateBackIfNoData_(), if we want, or just show the site with no entries. Might be good to have some "No permissions/storage" message though. Maybe we should get UX guidance here for items 1) and 3) above.

Comment 2 by tkonch...@chromium.org, Oct 24 2016

Labels: Proj-MaterialDesign-WebUI

Comment 3 by rolfe@chromium.org, Oct 26 2016

Cc: bettes@chromium.org tbuck...@chromium.org
+bettes@ is still working on the site details design and can consider how to show No.1 and 3 per comment 1. Hoping +tbuckley could triage among the Material priorities.

Comment 4 by bettes@chromium.org, Oct 31 2016 

This just might be an implementation error. Please assign to me if there's UX concerns.

Comment 5 Deleted

Comment 6 by dbeam@chromium.org, Jan 31 2017

Labels: -M-55 Hotlist-MD-Settings-Privacy-SiteSettings
only an issue --enable-site-settings

Comment 7 by rolfe@chromium.org, Mar 29 2017

Cc: -rolfe@chromium.org
Removing myself. If you need security UX, reach out to maxwalker, but thinking bettes@ has this well-covered.

Comment 8 by dschuyler@chromium.org, Apr 17 2017

Summary: [Site settings details] Unnecessary 'Add exception' is seen site settings even after Incognito session is ended. (was: Regression: Unnecessary 'Add exception' is seen site settings even after Incognito session is ended.)

Comment 9 by dschuyler@chromium.org, Apr 17 2017

Blocking: 712446

Comment 10 by dschuyler@chromium.org, May 19 2017

Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 11 by sheriffbot@chromium.org, May 21 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by dpa...@chromium.org, Jul 16

Cc: patricia...@chromium.org
Status: Available (was: Untriaged)
►

Sign in to add a comment