New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658628 link

Starred by 1 user
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Oct 2016
Cc:
█ y...@yoav.ws
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Preloading media files with type= attribute fails

Project Member Reported by kinuko@chromium.org, Oct 24 2016 
Version: ToT, 53.0.2785.143
OS: All

What steps will reproduce the problem?
Open a page with link preload= for media files with type attribute (like below)

<link rel=preload href="media/sample.webm" as=media type="video/webm">

What is the expected output?
The media file should be preloaded if the type is supposed by the client

What do you see instead?
The media file isn't preloaded
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d224439f14b05798771fdf327fae51ae420664

commit a7d224439f14b05798771fdf327fae51ae420664
Author: kinuko <kinuko@chromium.org>
Date: Mon Oct 24 10:02:41 2016

Cleanup WebMIMERegistry implementation and fix LinkLoader behavior

- Now that content/child can also depend on media just implement
  media related mime methods in SimpleWebMIMERegistry and remove
  renderer-only overrides.

- LinkLoader should use supportsMediaMIMEType rather than
  supportsMediaSourceMIMEType in as=media cases, as the latter
  is for MediaSource extension and always fails if empty codecs
  string is given (and that was what happening in the real renderer case)

BUG= 658628 
TEST=http/tests/preload/preload_with_type.html
TEST=LinkLoaderTest.Preload

Review-Url: https://codereview.chromium.org/2440163002
Cr-Commit-Position: refs/heads/master@{#427037}

[modify] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/content/child/simple_webmimeregistry_impl.cc
[modify] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/content/renderer/renderer_blink_platform_impl.cc
[add] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/third_party/WebKit/LayoutTests/http/tests/preload/preload_with_type.html
[add] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/third_party/WebKit/LayoutTests/http/tests/resources/test.wav
[add] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/third_party/WebKit/LayoutTests/http/tests/resources/test.webm
[modify] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/third_party/WebKit/Source/platform/MIMETypeRegistry.cpp
[modify] https://crrev.com/a7d224439f14b05798771fdf327fae51ae420664/third_party/WebKit/Source/platform/MIMETypeRegistry.h

Comment 2 by kinuko@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment