New issue
Advanced search Search tips

Issue 658613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in get

Project Member Reported by ClusterFuzz, Oct 23 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5693223965294592

Fuzzer: inferno_twister_custom_bundle
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000040
Crash State:
  get
  get
  blink::ComputedStyle::font
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=425380:425442

Minimized Testcase (1.89 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94b71b-Q_ndhbwa1XnaJ-GAt_94VNDriXUCSTDZLoaI3C3LTViPVZEJikz7hZwnY0eyYLJTAVGedsf8MX9t1QEguMMFuomTJAN4o3yOEFzL9HonnfVC5hrf2ISB9tIyAzXX21xUZzZTbCuEJV1aI1LDhjBtrg?testcase_id=5693223965294592

Additional requirements: Requires HTTP

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>SVG
Labels: Test-Predator-Correct
Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
Suspected CLs	
==============
The result is a list of CLs that change the crashed files.

Author: eae
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/fdcbab80bc37108f6e03d6906f27831228690350
Time: Fri Oct 14 19:47:55 2016
Lines 400, 408, 417-418, 425 of file SVGLengthContext.cpp which potentially caused crash are changed in this cl (frame #4, "blink::SVGLengthContext::convertValueFromUserUnitsToEXS").

File ComputedStyle.cpp is changed in this cl (and is part of stack frame #3, "blink::ComputedStyle::font")
Minimum distance from crash line to modified line: 0. (file: SVGLengthContext.cpp, crashed on: 400, modified: 400).

Suspected Project: chromium
Suspected Component: Blink>SVG

From the above CL list by Findit suspecting the below:
https://chromium.googlesource.com/chromium/src/+/fdcbab80bc37108f6e03d6906f27831228690350
eae@ : Could you please take a look into this if its related to your change.

Comment 2 by e...@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c55d78bcbaff133a4e688eddc7573e0609cf190

commit 4c55d78bcbaff133a4e688eddc7573e0609cf190
Author: fs <fs@opera.com>
Date: Mon Oct 24 16:18:24 2016

Fix more null-checks in SVGLengthContext::convertValueFrom*

The following methods in SVGLengthContext:

 convertValueFromUserUnitsToCHS
 convertValueFromUserUnitsToEXS
 convertValueFromEXSToUserUnits

needs the same treatment as convertValueFromCHSToUserUnits got in
https://chromiumcodereview.appspot.com/2445463002.

R=pdr@chromium.org,eae@chromium.org
BUG= 657438 , 658585 , 658613 

Review-Url: https://codereview.chromium.org/2449433002
Cr-Commit-Position: refs/heads/master@{#427080}

[modify] https://crrev.com/4c55d78bcbaff133a4e688eddc7573e0609cf190/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp

Project Member

Comment 4 by ClusterFuzz, Oct 25 2016

ClusterFuzz has detected this issue as fixed in range 427006:427199.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5693223965294592

Fuzzer: inferno_twister_custom_bundle
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000040
Crash State:
  get
  get
  blink::ComputedStyle::font
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=425380:425442
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_lsan_chrome_mp&range=427006:427199

Minimized Testcase (1.89 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94b71b-Q_ndhbwa1XnaJ-GAt_94VNDriXUCSTDZLoaI3C3LTViPVZEJikz7hZwnY0eyYLJTAVGedsf8MX9t1QEguMMFuomTJAN4o3yOEFzL9HonnfVC5hrf2ISB9tIyAzXX21xUZzZTbCuEJV1aI1LDhjBtrg?testcase_id=5693223965294592

Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment