New issue
Advanced search Search tips

Issue 658574 link

Starred by 1 user
Status: Fixed
Owner:
fmalita@chromium.org
Closed: Apr 2017
Cc:
rbasuvula@chromium.org
halcanary@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Element with SVG background and border-radius is rendered poorly on print

Reported by david.st...@gmail.com, Oct 23 2016 
Chrome Version       : 54.0.2840.71
URLs (if applicable) : https://jsfiddle.net/jvvf5a1a/
OS version               : macOS Sierra 10.12
Behavior in Safari Version 10.0 (12602.1.50.0.10): Renders beautifully
Behavior in Firefox 49.0.2: Only <img> tag is fine.
Behavior in Chrome for Windows: Not tested

What steps will reproduce the problem?
(1) Open https://jsfiddle.net/jvvf5a1a/
(2) Open the print preview (Cmd+P or File > Print..., or right-click > Print...)
(3) Make sure "Background graphics" is enabled
(4) Save in PDF or open in Preview

What is the expected result?
The three icons should be rendered properly.


What happens instead?
Middle icon is rendered very poorly, pixelated and blurry

I tried to find similar issues with no success.

Comment 1 by rbasuvula@chromium.org, Oct 25 2016

Cc: rbasuvula@chromium.org
Components: UI>Browser>PrintPreview
Labels: M-56 OS-Linux OS-Windows
Owner: fmalita@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue on chrome #54.0.2840.71 and Canary #56.0.2899.0 on MAC 10.12 and was able to reproduce the issue.

Bisect Information:
=====================
Good Build: 53.0.2746.0(Revision - 395278)
Bad Build: 53.0.2748.0(Revision - 395748)

Bisect URL:
=========== 
You are probably looking for a change made after 395484 (known good), but no later than 395496 (first known bad).
https://chromium.googlesource.com/chromium/src/+log/4be351834826fa6bc3576f63c144b88d75ea49d9..788f45b374a8ad32e8a9a6eb910ded1360f33caf

From the CL above, assigning the issue to the concern owner

@ fmalita:

Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/1949253004

Comment 2 by fmalita@chromium.org, Oct 25 2016

Cc: fmalita@chromium.org
Components: Internals>Skia>PDF
Owner: halcanary@chromium.org
Yes, this is triggered by my change, but likely a problem with the PDF backend.

Hal, I don't remember all the details, but I think we've had several bugs related to SkPDF shader raster quality.  Can you maybe dupe this against one of those bugs?

(that's what this CL changed: we now draw rounded-rect images with shaders)

Comment 3 by halcanary@google.com, Apr 10 2017 

What raster quality do you want?

Comment 4 by thestig@chromium.org, Apr 10 2017

Labels: -M-56
I'm guessing comment 3 is for fmalita@ ?

Comment 5 by fmalita@chromium.org, Apr 11 2017

Cc: -fmalita@chromium.org halcanary@chromium.org
Owner: fmalita@chromium.org
(not sure where the question was directed)

There is no good answer, all I was asking was to throw this issue in the stuff-that-is-poorly-supported-in-pdf-cause-shaders bucket.

But since the trigger change is an optimization for normal rendering, maybe we can disable it when printing and get back to the original behavior.  I'll take a look, although I'm not crazy about having different paint paths for printing/non-printing.

Comment 6 by fmalita@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)
Should be fixed after https://chromium.googlesource.com/chromium/src/+/7a295c16c670ed5c712fa109df65112be4b107a6.
►

Sign in to add a comment