New issue
Advanced search Search tips

Issue 658569 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Oct 2016
Cc:
aga...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

rietveld sometimes doesn't append +reviewer to reviewer email address

Project Member Reported by michae...@chromium.org, Oct 23 2016 
Generally, emails sent to a reviewer append +reviewer to the reviewer's email address, e.g.:

https://groups.google.com/a/chromium.org/d/msg/chromium-reviews/C2YDBs-WrAU/-6r1NZ_9AwAJ

the initial email was sent to [username]+reviewer@chromium.org.

This doesn't always work for some reason, e.g.:

https://groups.google.com/a/chromium.org/d/msg/chromium-reviews/FA37Zf5Cj7A/2VxsqxrvBAAJ

the initial email was sent to [username]@chromium.org.

This makes setting up filters for reviewer requests really difficult.

Comment 1 by aga...@chromium.org, Oct 24 2016

Status: WontFix (was: Untriaged)
Go to https://codereview.chromium.org/settings (in the old, non-polymer UI). There's a setting there:

Add plus role:	
Add +owner, +reviewer, or +cc to my email address when sending notifications.

I have that setting unchecked, which is why +reviewer wasn't added to my address in your test case.

This appears to be working as intended, so I'm going to close this issue. If you have seen actual inconsistencies in terms of it sometimes applying +foo, and sometimes not, for a single user, please re-open.
►

Sign in to add a comment