New issue
Advanced search Search tips

Issue 658520 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove NewMediaPlaybackUI flag

Project Member Reported by mlamouri@chromium.org, Oct 22 2016

Issue description

It should be used in all platforms at this point. Removing it will help clean up dead code :)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76

commit 8acbe326325ecfef82cd5d98b9ffd5f28e17ff76
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Oct 26 10:25:46 2016

Remove newMediaPlaybackUi flag from content/ and Blink.

The flag has been enabled by default for a while and makes the code more
complex. We no longer test the old code path which is likely broken at
this point.

A follow-up CL will remove the files that are now obsolete.

BUG= 658520 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2447503002
Cr-Commit-Position: refs/heads/master@{#427658}

[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/content/child/runtime_features.cc
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/content/public/common/content_features.cc
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/content/public/common/content_features.h
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/LayoutTests/media/video-controls-hidden-audio.html
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/8acbe326325ecfef82cd5d98b9ffd5f28e17ff76/third_party/WebKit/public/web/WebRuntimeFeatures.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81de2a463baa494992cdf9152e5330e5c7bfc37b

commit 81de2a463baa494992cdf9152e5330e5c7bfc37b
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Oct 26 10:32:25 2016

Remove obsolete media player resources.

Following https://codereview.chromium.org/2447503002

This clean up the resources that became obsolete now that the old media
player can no longer be used in Chromium.

BUG= 658520 

Review-Url: https://codereview.chromium.org/2447663002
Cr-Commit-Position: refs/heads/master@{#427660}

[modify] https://crrev.com/81de2a463baa494992cdf9152e5330e5c7bfc37b/content/child/blink_platform_impl.cc
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/Source/core/css/mediaControls.css
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/Source/core/css/mediaControlsAndroid.css
[modify] https://crrev.com/81de2a463baa494992cdf9152e5330e5c7bfc37b/third_party/WebKit/public/blink_image_resources.grd
[modify] https://crrev.com/81de2a463baa494992cdf9152e5330e5c7bfc37b/third_party/WebKit/public/blink_resources.grd
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_off.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_on.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption_disabled.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaptions_icon.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_fullscreen.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_fullscreen_disabled.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_off.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_play.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_pause.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_play.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_play_disabled.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_slider_thumb.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_disabled.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level0.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level1.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level2.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_level3.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_subtitles_icon.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_trackselection_checkmark.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb.png
[delete] https://crrev.com/f795cde5fb6c8218a465d9dfa4b0f9fae71bcdbc/third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb_disabled.png

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290242e6b8ad0dceb420758f86dc0c96febcaae1

commit 290242e6b8ad0dceb420758f86dc0c96febcaae1
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Oct 26 21:09:40 2016

Remove all "new" suffixes from media player assets.

Now that the "old" assets are out, we should leave the "new" namespace
for things that might actually be new-er :)

BUG= 658520 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2443903002
Cr-Commit-Position: refs/heads/master@{#427788}

[modify] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/content/child/blink_platform_impl.cc
[modify] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/Source/core/css/mediaControls.css
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/Source/core/css/mediaControlsAndroid.css
[modify] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/blink_image_resources.grd
[modify] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/blink_resources.grd
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_off.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_cast_on.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaption_disabled.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_closedcaptions_icon.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_off.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_cast_on.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_overlay_play.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_pause.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_play.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_slider_thumb.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_muted.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_sound_not_muted.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_subtitles_icon.png
[rename] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_trackselection_checkmark.png
[copy] https://crrev.com/290242e6b8ad0dceb420758f86dc0c96febcaae1/third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb.png
[delete] https://crrev.com/1b65767eda1eaf76059c5eea817b53b0c9fdf332/third_party/WebKit/public/default_100_percent/blink/mediaplayer_volume_slider_thumb_new.png

Status: Fixed (was: Started)
It's gone 👋

Sign in to add a comment