New issue
Advanced search Search tips

Issue 658479 link

Starred by 2 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Nov 2016
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

paint/invalidation/background-resize-height.html is flaky

Project Member Reported by pkasting@chromium.org, Oct 22 2016 
Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=paint%2Finvalidation%2Fbackground-resize-height.html

Sample failing run: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/18959

Most of the time this test requires many retries to pass; sometimes it fails entirely.  Looking at various bots' output, it seems that the expectations file has lines like:

    {
      "name": "LayoutBlockFlow (positioned) DIV class='test image'",
      "position": [8, 8],
      "bounds": [60, 44],
      "drawsContent": true,
      "backfaceVisibility": "hidden",
      "paintInvalidations": [
        {
          "object": "LayoutBlockFlow (positioned) DIV class='test image'",
          "rect": [0, 40, 60, 4],
          "reason": "incremental"
        }
      ]
    },
 
But the actual output adds

      "contentsOpaque": true,

Just below the bounds (and something similar happens many other places in the file).

It seems like the fix is:
* Force these objects to always or never be opaque, and make the expectations match that;
* Or, don't dump the opaque status in the output.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85a4d1bc1312da60223be13dedb26ea1d0a691e

commit d85a4d1bc1312da60223be13dedb26ea1d0a691e
Author: pkasting <pkasting@chromium.org>
Date: Sat Oct 22 03:25:11 2016

Mark a test as flaky.

BUG= 658479 
TEST=none
TBR=wangxianzhu

Review-Url: https://chromiumcodereview.appspot.com/2432043010
Cr-Commit-Position: refs/heads/master@{#426964}

[modify] https://crrev.com/d85a4d1bc1312da60223be13dedb26ea1d0a691e/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by schenney@chromium.org, Oct 31 2016

Status: Assigned (was: Untriaged)
I assume the test is flakey due to an image load race condition, which is what ultimately drives the opaque/non-opaque assessment. Assigning to wangxianzhu@ as they are best placed to decide on a test change. If the problem is an underlying bug (i.e. not timing related) then send it back to me.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/586f1b550af51392707deba2b9a1c9aaeeeb8bc9

commit 586f1b550af51392707deba2b9a1c9aaeeeb8bc9
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Nov 03 01:46:41 2016

Fix flaky test paint/invalidation/background-resize-height.html

Add capturePixelsThenAsync() to ensure image decoding is finished before
running the test, to avoid flakiness of "contentsOpaque" in the dumped
layer tree.

Also disabled the fixed height gradient case because it produces
invisible pixel difference.

BUG= 658479 

Review-Url: https://codereview.chromium.org/2464253002
Cr-Commit-Position: refs/heads/master@{#429506}

[modify] https://crrev.com/586f1b550af51392707deba2b9a1c9aaeeeb8bc9/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/586f1b550af51392707deba2b9a1c9aaeeeb8bc9/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height-expected.html
[modify] https://crrev.com/586f1b550af51392707deba2b9a1c9aaeeeb8bc9/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height-expected.txt
[modify] https://crrev.com/586f1b550af51392707deba2b9a1c9aaeeeb8bc9/third_party/WebKit/LayoutTests/paint/invalidation/background-resize-height.html
[delete] https://crrev.com/4801e0b7872b2f36dd285e02b8fb7bbc804add6c/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/background-resize-height-expected.txt
[delete] https://crrev.com/4801e0b7872b2f36dd285e02b8fb7bbc804add6c/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background-resize-height-expected.txt
[delete] https://crrev.com/4801e0b7872b2f36dd285e02b8fb7bbc804add6c/third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/background-resize-height-expected.txt

Comment 4 by wangxianzhu@chromium.org, Nov 3 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment