New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658473 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix misleading TEST_NA message for missing hardware dependency

Project Member Reported by briannorris@chromium.org, Oct 22 2016

Issue description

Note: take all my claims with a grain of salt. Feel free to close.

---

https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_speedy-paladin/builds/3426/

  cheets_CTS.6.0_r9.x86.android.core.tests.libcore.package.harmony_java_math   [  INFO  ]
  cheets_CTS.6.0_r9.x86.android.core.tests.libcore.package.harmony_java_math     TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp9.mse                                             [  INFO  ]
  video_ChromeHWDecodeUsed.vp9.mse                                               TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp9                                                 [  INFO  ]
  video_ChromeHWDecodeUsed.vp9                                                   TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp9.arc                                             [  INFO  ]
  video_ChromeHWDecodeUsed.vp9.arc                                               TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeCameraMJpegHWDecodeUsed                                          [  INFO  ]
  video_ChromeCameraMJpegHWDecodeUsed                                            TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeCameraMJpegHWDecodeUsed.arc                                      [  INFO  ]
  video_ChromeCameraMJpegHWDecodeUsed.arc                                        TEST_NA: Test skipped, no DUTs with expected labels found
  graphics_dEQP.gles2.accuracy                                                 [ FAILED ]
  graphics_dEQP.gles2.accuracy                                                   ABORT: Timed out, did not run.
  graphics_dEQP.gles2.capability                                               [ FAILED ]
  graphics_dEQP.gles2.capability                                                 ABORT: Timed out, did not run.


It looks like wolf had a similar issue too:

https://uberchromegw.corp.google.com/i/chromeos/builders/wolf-tot-paladin/builds/8141

  Suite job                                 [ PASSED ]
  video_ChromeRTCHWEncodeUsed.arc           [  INFO  ]
  video_ChromeRTCHWEncodeUsed.arc             TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp8.mse          [  INFO  ]
  video_ChromeHWDecodeUsed.vp8.mse            TEST_NA: Test skipped, no DUTs with expected labels found
  telemetry_LoginTest.arc                   [  INFO  ]
  telemetry_LoginTest.arc                     TEST_NA: Test skipped, no DUTs with expected labels found
  video_VideoSanity.h264.arc                [  INFO  ]
  video_VideoSanity.h264.arc                  TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp8              [  INFO  ]
  video_ChromeHWDecodeUsed.vp8                TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp9.arc          [  INFO  ]
  video_ChromeHWDecodeUsed.vp9.arc            TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeRTCHWDecodeUsed               [  INFO  ]
  video_ChromeRTCHWDecodeUsed                 TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeCameraMJpegHWDecodeUsed.arc   [  INFO  ]
  video_ChromeCameraMJpegHWDecodeUsed.arc     TEST_NA: Test skipped, no DUTs with expected labels found
  video_VideoSanity.vp8.arc                 [  INFO  ]
  video_VideoSanity.vp8.arc                   TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeRTCHWEncodeUsed               [  INFO  ]
  video_ChromeRTCHWEncodeUsed                 TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.h264.arc         [  INFO  ]
  video_ChromeHWDecodeUsed.h264.arc           TEST_NA: Test skipped, no DUTs with expected labels found
  graphics_Idle.arc                         [  INFO  ]
  graphics_Idle.arc                           TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeRTCHWDecodeUsed.arc           [  INFO  ]
  video_ChromeRTCHWDecodeUsed.arc             TEST_NA: Test skipped, no DUTs with expected labels found
  video_ChromeHWDecodeUsed.vp8.arc          [  INFO  ]
  video_ChromeHWDecodeUsed.vp8.arc            TEST_NA: Test skipped, no DUTs with expected labels found
  video_VideoSanity.vp9.arc                 [  INFO  ]
  video_VideoSanity.vp9.arc                   TEST_NA: Test skipped, no DUTs with expected labels found
  desktopui_ExitOnSupervisedUserCrash.arc   [  INFO  ]
  desktopui_ExitOnSupervisedUserCrash.arc     TEST_NA: Test skipped, no DUTs with expected labels found
  Sound System Validation                   [ FAILED ]
  Sound System Validation                     ABORT: Timed out, did not run.
 
Components: -Infra>Labs>HWOps Infra>Client>ChromeOS
Status: Available (was: Untriaged)
Summary: Fix misleading TEST_NA message for missing hardware dependency (was: DUT availability for veyron_speedy and wolf)
The message doesn't indicate an error; it indicates that the
selected board doesn't provide the hardware support required
for the given test.

The fact that this bug got filed means that the message needs
to get fixed.

Also:  Bugs in the Chrome OS test infrastructure should be
filed against component Infra>Client>ChromeOS.

My recommendation for the new message:
    Test not supported for this board.

Thanks for all the corrections.

But what about the FAILED marking, with timeouts? Both of these paladin runs caused the CQ run to fail.
paladin/R56-8921.0.0-rc1, pool:bvt, board:wolf.
Traceback (most recent call last):
  File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line 114, in dispatchRequest
    results['result'] = self.invokeServiceEndpoint(meth, args)
  File "/usr/local/autotest/frontend/afe/json_rpc/serviceHandler.py", line 154, in invokeServiceEndpoint
    return meth(*args)
  File "/usr/local/autotest/frontend/afe/rpc_handler.py", line 270, in new_fn
    return f(*args, **keyword_args)
  File "/usr/local/autotest/frontend/afe/rpc_utils.py", line 1347, in replacement
    return func(**kwargs)
  File "/usr/local/autotest/frontend/afe/rpc_interface.py", line 1002, in create_job
    **rpc_utils.get_create_job_common_args(locals()))
  File "/usr/local/autotest/frontend/afe/rpc_utils.py", line 1019, in create_job_common
    atomic_group=atomic_group)
  File "/usr/local/autotest/frontend/afe/rpc_utils.py", line 621, in create_new_job
    check_job_metahost_dependencies(metahost_objects, dependencies)
  File "/usr/local/autotest/frontend/afe/rpc_utils.py", line 362, in check_job_metahost_dependencies
    % (metahost.name, ', '.join(job_dependencies)))
NoEligibleHostException: No hosts within board:wolf satisfy arc, cros-version:wolf-tot-paladin/R56-8921.0.0-rc1, pool:bvt, board:wolf.



---

Are we scheduling ARC++ tests for wolf?
> But what about the FAILED marking, with timeouts?
> Both of these paladin runs caused the CQ run to fail.

Ah yes, that.  That's a failure.  In this case "did not run"
means the test couldn't get scheduled before the entire suite
timed out.  That's worth a new bug.

Preview for the new bug:  There are two common explanations
for this symptom:
 1) The target build was unstable in a way that slowed down
    testing (often because of Chrome crashes).
 2) The test scheduler was (temporarily) overloaded in some
    way.

> Are we scheduling ARC++ tests for wolf?

Yes, we schedule ARC++ tests for all boards, because they're
in the suite.  For boards (like wolf) that don't support ARC++,
the tests don't run, with the various symptoms already noted.

Same thing goes for various other tests (e.g. the cited video
tests).
I filed  issue 658469  for the Sound System Validation failure, but I don't have much extra info.
And about the $subject, yes, I think I've misinterpreted that before. I've previously at least understood that "TEST_NA" meant we didn't care about the "problem." I didn't realize in this case it was simply a way to skip inapplicable tests.

It also didn't help that there were other failures alongside, so I figured mention them all. If this didn't result in a red build, I wouldn't have worried :)

But if we are looking to change the message, it sounds like comment #2's suggestion would help people like me. As long as that's an accurate message, SGTM.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c91299910fb82b8b9092a67342d1e2340f5816fe

commit c91299910fb82b8b9092a67342d1e2340f5816fe
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Mon Oct 24 15:38:26 2016

[autotest] Fix message for a test on unsupported hardware.

When a test with a hardware dependency was determined to be
unsupported on a given board, the message said "no DUTs with
expected labels".  That message was nominally accurate, but the
target audience (Sheriffs) didn't know what it meant.  This changes
the message to say simply "test not supported on this board".

BUG= chromium:658473 
TEST=None

Change-Id: I1a9c02b20bb63b193f00b9d81d9db684f36c9887
Reviewed-on: https://chromium-review.googlesource.com/402061
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/c91299910fb82b8b9092a67342d1e2340f5816fe/server/cros/dynamic_suite/suite.py

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c91299910fb82b8b9092a67342d1e2340f5816fe

commit c91299910fb82b8b9092a67342d1e2340f5816fe
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Mon Oct 24 15:38:26 2016

[autotest] Fix message for a test on unsupported hardware.

When a test with a hardware dependency was determined to be
unsupported on a given board, the message said "no DUTs with
expected labels".  That message was nominally accurate, but the
target audience (Sheriffs) didn't know what it meant.  This changes
the message to say simply "test not supported on this board".

BUG= chromium:658473 
TEST=None

Change-Id: I1a9c02b20bb63b193f00b9d81d9db684f36c9887
Reviewed-on: https://chromium-review.googlesource.com/402061
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/c91299910fb82b8b9092a67342d1e2340f5816fe/server/cros/dynamic_suite/suite.py

Status: Fixed (was: Available)
We'll need a push to prod before the impact of this change
shows up in suite logs, but the code change is done.

Comment 13 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 14 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 15 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment