New issue
Advanced search Search tips

Issue 658461 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 637272
issue 658463



Sign in to add a comment

Display Pref Printers in Print Preview Dialog

Project Member Reported by skau@chromium.org, Oct 21 2016

Issue description

Rewire print preview dialog so preference printers are displayed instead of backend printers.
 

Comment 1 by skau@chromium.org, Oct 22 2016

Blocking: 658463
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7314c0fda0d093c22ceeba08ad00e88695e9d64

commit f7314c0fda0d093c22ceeba08ad00e88695e9d64
Author: skau <skau@chromium.org>
Date: Sat Nov 05 00:12:09 2016

Present the printer list from preferences for Chrome OS.

Chrome OS keeps the canonical printer listing in preferences rather than
in the printing backend.  Add a new codepath on this platform.

CL 1 of 3 to enable printer selection on Chrome OS

BUG= 658461 
TEST=Verified that printers from preferences show up in printer selection.

Review-Url: https://codereview.chromium.org/2463473002
Cr-Commit-Position: refs/heads/master@{#430072}

[modify] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/chrome/browser/ui/webui/print_preview/print_preview_handler.h
[add] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/chrome/browser/ui/webui/print_preview/printer_backend_proxy.cc
[add] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/chrome/browser/ui/webui/print_preview/printer_backend_proxy.h
[add] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
[modify] https://crrev.com/f7314c0fda0d093c22ceeba08ad00e88695e9d64/printing/backend/print_backend.h

Comment 3 by skau@chromium.org, Nov 5 2016

Status: Fixed (was: Assigned)

Comment 4 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 5 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment