New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658448 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Quick view: open in gallery doesn't work in the save as dialog

Project Member Reported by dhadd...@chromium.org, Oct 21 2016

Issue description

1. Go to Chrome
2. search for pictures of pugs
3. Right click the image
4. In the save as dialog that appears, click an existing file
5. Press space key

Expected: There is no open button
Actual: Open button appears.
 

Comment 1 by fukino@chromium.org, Oct 24 2016

Cc: -oka@chromium.org
Owner: oka@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by oka@chromium.org, Nov 7 2016

We shouldn't show the open icon in save as dialog.

Comment 4 by oka@chromium.org, Jan 16 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88a01ea6624dcffe4257a05e79c56ccd5eb31849

commit 88a01ea6624dcffe4257a05e79c56ccd5eb31849
Author: oka <oka@chromium.org>
Date: Tue Jan 17 09:11:43 2017

Refactor Quick View controller.

Refactored the logic to fill parameters into quick view element
using switch instead of multiple if-s.
This is a preparation for the CL https://codereview.chromium.org/2634053002, which
shows open task button only when applicable.

BUG= 658448 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2631143002
Cr-Commit-Position: refs/heads/master@{#444009}

[modify] https://crrev.com/88a01ea6624dcffe4257a05e79c56ccd5eb31849/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d

commit a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d
Author: oka <oka@chromium.org>
Date: Tue Jan 17 09:30:55 2017

Show open task button only when applicable.

In Quick View, the open task button should be shown only when
1. The dialog is full page mode, and
2. There is a task to open the file.
In this CL, hasTask property is added to files-quick-view element
and quick view controller sets it true only if 1 and 2 are satisfied.

BUG= 658448 
TEST=manually checked the following cases:
file type | volume   | has open button
--------------------------------------
image     | Download | yes
image     | Drive    | yes
folder    | Download | no
folder    | Drive    | no

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2634053002
Cr-Commit-Position: refs/heads/master@{#444011}

[modify] https://crrev.com/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[modify] https://crrev.com/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
[modify] https://crrev.com/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Comment 7 by oka@chromium.org, Jan 17 2017

Status: Fixed (was: Started)

Comment 8 by oka@chromium.org, Jan 17 2017

Description: Show this description
Status: Verified (was: Fixed)
58.0.3007.0/9270.0.0

Sign in to add a comment