New issue
Advanced search Search tips

Issue 658432 link

Starred by 2 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 343579



Sign in to add a comment

Add support for 0-RTT for first request from Chromium to QUIC data saver proxy

Project Member Reported by tbansal@chromium.org, Oct 21 2016 
The first request of the session from Chromium to QUIC data saver proxy currently takes at least 1-RTT. This is because the properties of the QUIC data saver server are not persisted on the disk.

The plan is to add the data saver QUIC server to the list of QUIC supported servers at startup in net::QuicStreamFactory class. That will enable Chromium to use 0-RTT even for the first request to the proxy.

Comment 1 by tbansal@chromium.org, Oct 24 2016

Labels: -M-56 M-55
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b96695ae3cd9d92050740d6741ffae04f5c4cb7

commit 3b96695ae3cd9d92050740d6741ffae04f5c4cb7
Author: tbansal <tbansal@chromium.org>
Date: Tue Oct 25 23:25:14 2016

Add a QUIC proxy server to the list of QUIC servers supported at start up

Data reduction proxy server is added to the list of QUIC
servers supported at start up. This will enable 0-RTT
requests for the first request to the data reduction QUIC
proxy (provided Chromium has used QUIC in the past to
connect to the data reduction proxy).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet

BUG= 658432 

Review-Url: https://codereview.chromium.org/2442633002
Cr-Commit-Position: refs/heads/master@{#427531}

[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/base/proxy_delegate.h
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/base/test_proxy_delegate.h
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/http/http_network_session.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/3b96695ae3cd9d92050740d6741ffae04f5c4cb7/tools/metrics/histograms/histograms.xml

Comment 3 by tbansal@chromium.org, Oct 26 2016

Labels: Merge-Request-55
Requesting merge to M-55.

Comment 4 by dimu@chromium.org, Oct 26 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43

commit 94ddeb003c4cfa9ed7f2f912856c36feb9b98b43
Author: Tarun Bansal <tbansal@google.com>
Date: Wed Oct 26 23:15:00 2016

Add a QUIC proxy server to the list of QUIC servers supported at start up

Data reduction proxy server is added to the list of QUIC
servers supported at start up. This will enable 0-RTT
requests for the first request to the data reduction QUIC
proxy (provided Chromium has used QUIC in the past to
connect to the data reduction proxy).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet

BUG= 658432 

Review-Url: https://codereview.chromium.org/2442633002
Cr-Commit-Position: refs/heads/master@{#427531}
(cherry picked from commit 3b96695ae3cd9d92050740d6741ffae04f5c4cb7)

Review URL: https://codereview.chromium.org/2453973003 .

Cr-Commit-Position: refs/branch-heads/2883@{#323}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/base/proxy_delegate.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/base/test_proxy_delegate.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/http/http_network_session.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/tools/metrics/histograms/histograms.xml

Comment 6 by tbansal@chromium.org, Oct 27 2016

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43

commit 94ddeb003c4cfa9ed7f2f912856c36feb9b98b43
Author: Tarun Bansal <tbansal@google.com>
Date: Wed Oct 26 23:15:00 2016

Add a QUIC proxy server to the list of QUIC servers supported at start up

Data reduction proxy server is added to the list of QUIC
servers supported at start up. This will enable 0-RTT
requests for the first request to the data reduction QUIC
proxy (provided Chromium has used QUIC in the past to
connect to the data reduction proxy).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet

BUG= 658432 

Review-Url: https://codereview.chromium.org/2442633002
Cr-Commit-Position: refs/heads/master@{#427531}
(cherry picked from commit 3b96695ae3cd9d92050740d6741ffae04f5c4cb7)

Review URL: https://codereview.chromium.org/2453973003 .

Cr-Commit-Position: refs/branch-heads/2883@{#323}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/base/proxy_delegate.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/base/test_proxy_delegate.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/base/test_proxy_delegate.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/http/http_network_session.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/proxy/proxy_service_unittest.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/quic/chromium/quic_stream_factory.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/quic/chromium/quic_stream_factory.h
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/quic/chromium/quic_stream_factory_test.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/net/websockets/websocket_end_to_end_test.cc
[modify] https://crrev.com/94ddeb003c4cfa9ed7f2f912856c36feb9b98b43/tools/metrics/histograms/histograms.xml

Comment 8 by dimu@google.com, Nov 4 2016 

[Automated comment] removing mislabelled merge-merged-2840

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment