Limit VTVideoEncodeAccelerator's keyframe output |
||||||||
Issue descriptionVTVideoEncodeAccelerator currently does not control keyframe output duration and lets it to be VideoToolbox implementation default. On Macbook Air 2013, this results in a keyframe every ~5 seconds, which is too often for some apps. We should limit this.
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d279e0818e6b27c0374ee8782748c6e3859785f commit 3d279e0818e6b27c0374ee8782748c6e3859785f Author: emircan <emircan@chromium.org> Date: Mon Oct 24 20:54:04 2016 Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG= 658429 TEST=AppRTC loopback on Mac. Review-Url: https://codereview.chromium.org/2431223011 Cr-Commit-Position: refs/heads/master@{#427143} [modify] https://crrev.com/3d279e0818e6b27c0374ee8782748c6e3859785f/media/gpu/vt_video_encode_accelerator_mac.cc
,
Oct 25 2016
Could someone please help us with a sample test case so that test team can verify this issue if required. Thanks.!
,
Oct 25 2016
This issue is originally reported by Cisco Webex. They stated that for their 90p thumbnail streams(90p), they receive keyframes every ~2 seconds and video is choppy. I cannot share their product details here. However, we can also test it via using an AppRTC loopback using link below: https://apprtc.appspot.com/r/391320966?debug=loopback&vsc=h264&video=maxHeight=90
,
Oct 25 2016
,
Oct 25 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dacc24d13122baa4c1659f9f7bc801f668a644d commit 1dacc24d13122baa4c1659f9f7bc801f668a644d Author: emircan <emircan@chromium.org> Date: Tue Oct 25 22:20:33 2016 Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG= 658429 TEST=AppRTC loopback on Mac. Review-Url: https://codereview.chromium.org/2431223011 Cr-Commit-Position: refs/heads/master@{#427143} (cherry picked from commit 3d279e0818e6b27c0374ee8782748c6e3859785f) NOTRY=true NOPRESUBMIT=true TBR=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2450993002 Cr-Commit-Position: refs/branch-heads/2883@{#302} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1dacc24d13122baa4c1659f9f7bc801f668a644d/media/gpu/vt_video_encode_accelerator_mac.cc
,
Oct 25 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dacc24d13122baa4c1659f9f7bc801f668a644d commit 1dacc24d13122baa4c1659f9f7bc801f668a644d Author: emircan <emircan@chromium.org> Date: Tue Oct 25 22:20:33 2016 Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG= 658429 TEST=AppRTC loopback on Mac. Review-Url: https://codereview.chromium.org/2431223011 Cr-Commit-Position: refs/heads/master@{#427143} (cherry picked from commit 3d279e0818e6b27c0374ee8782748c6e3859785f) NOTRY=true NOPRESUBMIT=true TBR=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2450993002 Cr-Commit-Position: refs/branch-heads/2883@{#302} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1dacc24d13122baa4c1659f9f7bc801f668a644d/media/gpu/vt_video_encode_accelerator_mac.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by emir...@chromium.org
, Oct 21 2016