New issue
Advanced search Search tips

Issue 658428 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocking:
issue 649343



Sign in to add a comment

Expose RTCDataChannel and RTCDataChannelEvent (with constructor)

Project Member Reported by foolip@chromium.org, Oct 21 2016

Issue description

https://w3c.github.io/webrtc-pc/#rtcdatachannel

These currently have [NoInterfaceObject]. For RTCDataChannel it's a simple matter of removing it, and for RTCDataChannelEvent the constructor will need to be added.
 

Comment 1 by foolip@chromium.org, Oct 27 2016

Owner: lunalu@chromium.org
Status: Assigned (was: Started)
lunalu@ will work on this. (Not immediately, but soon enough.)

Comment 2 by lunalu@chromium.org, Oct 31 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9191ae53bb551191f78e94326a989f50f6c55c09

commit 9191ae53bb551191f78e94326a989f50f6c55c09
Author: lunalu <lunalu@chromium.org>
Date: Tue Nov 15 20:46:18 2016

Expose RTCDataChannel and RTCDataChannelEvent (with constructor)

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zp-bVSF8PpY/h_IB2O0PAQAJ

For RTCDataChannel, simply remove [NoInterfaceObject] and for
RTCDataChannelEvent, the constructor is added.

BUG= 658428 

Review-Url: https://codereview.chromium.org/2463953002
Cr-Commit-Position: refs/heads/master@{#432248}

[add] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/LayoutTests/fast/peerconnection/RTCDataChannelEvent-constructor.html
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.idl
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.cpp
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.h
[modify] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl
[add] https://crrev.com/9191ae53bb551191f78e94326a989f50f6c55c09/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEventInit.idl

Comment 4 by lunalu@chromium.org, Nov 15 2016

Status: Fixed (was: Started)
Labels: M-57

Comment 6 by rbyers@chromium.org, Jul 18 2017

Owner: loonyb...@chromium.org

Sign in to add a comment