New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658414 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

canvas-lose-restore-googol-size.html is flaky

Project Member Reported by pkasting@chromium.org, Oct 21 2016

Issue description

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-lose-restore-googol-size.html&testType=webkit_tests

Sample failing run: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)/builds/7825

Expected output:


Tests to ensure correct behaviour of canvas loss and restoration when size is extremely large then, restored to a reasonable value.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS contextLostTest is false
PASS ctx.isContextLost() is false
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS successfullyParsed is true

TEST COMPLETE
PASS Graphics context lost event dispatched.
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS Context restored event dispatched after context lost.
PASS contextLostTest is false
PASS ctx.isContextLost() is false


Actual output:


Tests to ensure correct behaviour of canvas loss and restoration when size is extremely large then, restored to a reasonable value.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS contextLostTest is false
PASS ctx.isContextLost() is false
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS Graphics context lost event dispatched.
PASS contextLostTest is true
PASS ctx.isContextLost() is true
PASS Context restored event dispatched after context lost.
PASS contextLostTest is false
PASS ctx.isContextLost() is false
PASS successfullyParsed is true

TEST COMPLETE


Note that the actual output looks similar to the expected output, but reordered; it seems like there are timing issues with how events are dispatched?

I think flakiness started pretty recently, but not sure why.  ->junov to triage.
 

Comment 1 by junov@chromium.org, Oct 24 2016

Components: -Internals>GPU>Canvas2D Blink>Canvas
Status: Available (was: Untriaged)
The timing of the async even listeners are the issue here.  We could just refactor the test to use testharness.js, which will probably fix the issue.  We should also decide whether we want to ship or remove the 2d canvas context loss feature (whic is the object of this test.  It was prototyped a long time ago, and never shipped...

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc595432d97064286db8e2bdda3d8eb2119dbfc

commit fdc595432d97064286db8e2bdda3d8eb2119dbfc
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Dec 07 19:49:24 2016

Update TestExpectations by running Tools/Scripts/update-test-expectations.

This script removes lines for tests that appear to no longer flakily fail or timeout on the applicable platforms, according to recent results on the flakiness dashboard.

BUG=248938,446385, 513143 ,518987,522647, 532643 , 564403 , 569901 , 581468 , 605525 , 658311 , 658414 ,660308, 667953 , 671618 

Review-Url: https://codereview.chromium.org/2557593006
Cr-Commit-Position: refs/heads/master@{#437038}

[modify] https://crrev.com/fdc595432d97064286db8e2bdda3d8eb2119dbfc/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by junov@chromium.org, Dec 13 2016

Status: WontFix (was: Available)
No longer flaky -> WontFix

Sign in to add a comment