here are screenshots for updated TeleportWarningView/MultiprofilesIntroView

Deleted: puBE3aSaAif.png 108 KB

	puBE3aSaAif.png 108 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8

commit a02af5e6818e4e5e89a5c594557d5389b9d6c4a8
Author: estade <estade@chromium.org>
Date: Sat Oct 22 00:25:02 2016

Update two chromeos system dialogs to reuse more DialogDelegateView
functionality.

Screenshots on the bug - this is so vastly better looking IMO as to not
need UI review.

BUG= 658410 , 633986 

Review-Url: https://chromiumcodereview.appspot.com/2439863004
Cr-Commit-Position: refs/heads/master@{#426934}

[modify] https://crrev.com/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8/chrome/app/generated_resources.grd
[modify] https://crrev.com/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc
[modify] https://crrev.com/a02af5e6818e4e5e89a5c594557d5389b9d6c4a8/chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f1173f1e5a5678cc6c7cc9046939447398eaf19

commit 5f1173f1e5a5678cc6c7cc9046939447398eaf19
Author: estade <estade@chromium.org>
Date: Fri Oct 28 18:42:45 2016

Use a standard message box for DesktopCastingWarningView.

This is even simpler than what I did for TeleportWarningView, which
means I should probably go back and re-rewrite that one.

BUG= 658410 

Review-Url: https://codereview.chromium.org/2441403003
Cr-Commit-Position: refs/heads/master@{#428440}

[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/chrome/browser/ui/ash/multi_user/user_switch_util.cc
[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/chrome/browser/ui/ash/multi_user/user_switch_util.h
[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc
[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/chrome/browser/ui/cocoa/simple_message_box_mac.mm
[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/chrome/browser/ui/simple_message_box.h
[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/chrome/browser/ui/views/simple_message_box_views.cc
[modify] https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19/components/constrained_window/constrained_window_views.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca985a76bd8a84c1580e09cc4c621b499e2530b

commit bca985a76bd8a84c1580e09cc4c621b499e2530b
Author: kjellander <kjellander@chromium.org>
Date: Wed Nov 02 12:34:44 2016

Revert of Use a standard message box for DesktopCastingWarningView. (patchset #5 id:80001 of https://codereview.chromium.org/2441403003/ )

Reason for revert:
Speculative revert for flaky interactive_ui_tests on Mac10.10 Tests. See  crbug.com/661550 .

Original issue's description:
> Use a standard message box for DesktopCastingWarningView.
>
> This is even simpler than what I did for TeleportWarningView, which
> means I should probably go back and re-rewrite that one.
>
> BUG= 658410 
>
> Committed: https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19
> Cr-Commit-Position: refs/heads/master@{#428440}

TBR=derat@chromium.org,msw@chromium.org,estade@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 658410 ,  661550 

Review-Url: https://codereview.chromium.org/2469853003
Cr-Commit-Position: refs/heads/master@{#429256}

[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/chrome/browser/ui/ash/multi_user/user_switch_util.cc
[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/chrome/browser/ui/ash/multi_user/user_switch_util.h
[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc
[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/chrome/browser/ui/cocoa/simple_message_box_mac.mm
[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/chrome/browser/ui/simple_message_box.h
[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/chrome/browser/ui/views/simple_message_box_views.cc
[modify] https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b/components/constrained_window/constrained_window_views.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2befbdd78b547659e47298b68462f763404962c9

commit 2befbdd78b547659e47298b68462f763404962c9
Author: kjellander <kjellander@chromium.org>
Date: Wed Nov 02 14:09:16 2016

Reland of Use a standard message box for DesktopCastingWarningView. (patchset #1 id:1 of https://codereview.chromium.org/2469853003/ )

Reason for revert:
Relanding as a new build showed the same flake: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8584

Original issue's description:
> Revert of Use a standard message box for DesktopCastingWarningView. (patchset #5 id:80001 of https://codereview.chromium.org/2441403003/ )
>
> Reason for revert:
> Speculative revert for flaky interactive_ui_tests on Mac10.10 Tests. See  crbug.com/661550 .
>
> Original issue's description:
> > Use a standard message box for DesktopCastingWarningView.
> >
> > This is even simpler than what I did for TeleportWarningView, which
> > means I should probably go back and re-rewrite that one.
> >
> > BUG= 658410 
> >
> > Committed: https://crrev.com/5f1173f1e5a5678cc6c7cc9046939447398eaf19
> > Cr-Commit-Position: refs/heads/master@{#428440}
>
> TBR=derat@chromium.org,msw@chromium.org,estade@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG= 658410 ,  661550 
>
> Committed: https://crrev.com/bca985a76bd8a84c1580e09cc4c621b499e2530b
> Cr-Commit-Position: refs/heads/master@{#429256}

TBR=derat@chromium.org,msw@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 658410 ,  661550 

Review-Url: https://codereview.chromium.org/2468873005
Cr-Commit-Position: refs/heads/master@{#429269}

[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/chrome/browser/ui/ash/multi_user/user_switch_util.cc
[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/chrome/browser/ui/ash/multi_user/user_switch_util.h
[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc
[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/chrome/browser/ui/cocoa/simple_message_box_mac.mm
[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/chrome/browser/ui/simple_message_box.h
[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/chrome/browser/ui/views/simple_message_box_views.cc
[modify] https://crrev.com/2befbdd78b547659e47298b68462f763404962c9/components/constrained_window/constrained_window_views.cc

TeleportWarningView/MultiprofilesIntroView could use the simple message box stuff, but they have a checkbox AND ask a question, which isn't currently supported. I don't plan to chase this rabbit hole any more, so I'm marking this fixed.