New issue
Advanced search Search tips

Issue 658400 link

Starred by 2 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Toggling collate checkbox shifts contents by 2px.

Project Member Reported by dpa...@chromium.org, Oct 21 2016 
Showing/hiding the collate checkbox causes a 2px flicker, because the height of the copies settings-box is changing from 24px to 26px, see attachment.

@rbpotter: Can you take a look? I think this was caused by https://codereview.chromium.org/2441493004.
two_pixel_flicker.mp4
139 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/354fdaa367130497882b1c1421ba30882d19ca00

commit 354fdaa367130497882b1c1421ba30882d19ca00
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Oct 22 06:10:45 2016

Fix 2 pixel flicker from collate box

Modifies padding on top of collate box so that it does not cause a
flicker when it appears next to the new copies input field.

BUG= 658400 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2442743003
Cr-Commit-Position: refs/heads/master@{#426983}

[modify] https://crrev.com/354fdaa367130497882b1c1421ba30882d19ca00/chrome/browser/resources/print_preview/settings/copies_settings.css

Comment 2 by rbpotter@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment